Skip to content

Commit 7e49c5f

Browse files
committed
docs(SPEC-20): Mark Phase 5 cleanup as complete
All Phase 5 tasks completed: - Removed mount_commands.py and all mount functionality - Removed all tenant-wide bisync functions - Removed bisync_config from config schema - Simplified cloud setup command - Removed top-level sync command - All typecheck errors resolved
1 parent c25d45d commit 7e49c5f

1 file changed

Lines changed: 27 additions & 26 deletions

File tree

specs/SPEC-20 Simplified Project-Scoped Rclone Sync.md

Lines changed: 27 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,32 +1025,33 @@ rm -rf ~/basic-memory-cloud-sync/
10251025
- [ ] Add helper functions: `get_all_sync_projects()`, `get_project_by_name()` (optional)
10261026
- [ ] Write integration tests for new commands (deferred)
10271027

1028-
### Phase 5: Cleanup (1 day)
1029-
- [ ] Remove `mount_commands.py` (entire file)
1030-
- [ ] Remove mount-related functions from `rclone_config.py`:
1031-
- [ ] `MOUNT_PROFILES`
1032-
- [ ] `get_default_mount_path()`
1033-
- [ ] `build_mount_command()`
1034-
- [ ] `is_path_mounted()`
1035-
- [ ] `get_rclone_processes()`
1036-
- [ ] `kill_rclone_process()`
1037-
- [ ] `unmount_path()`
1038-
- [ ] `cleanup_orphaned_rclone_processes()`
1039-
- [ ] Remove from `bisync_commands.py`:
1040-
- [ ] `BISYNC_PROFILES` (use single default)
1041-
- [ ] `setup_cloud_bisync()`
1042-
- [ ] `run_bisync_watch()`
1043-
- [ ] `show_bisync_status()`
1044-
- [ ] Remove `bisync_config` from config schema
1045-
- [ ] Remove deprecated cloud commands:
1046-
- [ ] `cloud mount`
1047-
- [ ] `cloud unmount`
1048-
- [ ] `cloud mount-status`
1049-
- [ ] `cloud bisync-setup`
1050-
- [ ] Remove convenience commands:
1051-
- [ ] Root-level `bm sync` (without project)
1052-
- [ ] Root-level `bm bisync` (without project)
1053-
- [ ] Update tests to remove references to deprecated functionality
1028+
### Phase 5: Cleanup (1 day) ✅
1029+
- [x] Remove `mount_commands.py` (entire file)
1030+
- [x] Remove mount-related functions from `rclone_config.py`:
1031+
- [x] `MOUNT_PROFILES`
1032+
- [x] `get_default_mount_path()`
1033+
- [x] `build_mount_command()`
1034+
- [x] `is_path_mounted()`
1035+
- [x] `get_rclone_processes()`
1036+
- [x] `kill_rclone_process()`
1037+
- [x] `unmount_path()`
1038+
- [x] `cleanup_orphaned_rclone_processes()`
1039+
- [x] Remove from `bisync_commands.py`:
1040+
- [x] `BISYNC_PROFILES` (use single default)
1041+
- [x] `setup_cloud_bisync()`
1042+
- [x] `run_bisync_watch()`
1043+
- [x] `show_bisync_status()`
1044+
- [x] `run_bisync()`
1045+
- [x] `run_check()`
1046+
- [x] Remove `bisync_config` from config schema
1047+
- [x] Remove deprecated cloud commands:
1048+
- [x] `cloud mount`
1049+
- [x] `cloud unmount`
1050+
- [x] Simplified `cloud setup` to just install rclone and configure credentials
1051+
- [x] Remove convenience commands:
1052+
- [x] Root-level `bm sync` (removed - confusing in cloud mode, automatic in local mode)
1053+
- [x] Update tests to remove references to deprecated functionality
1054+
- [x] All typecheck errors resolved
10541055

10551056
### Phase 6: Documentation (1 day)
10561057
- [ ] Update `docs/cloud-cli.md` with new workflow

0 commit comments

Comments
 (0)