fix(sync): hash one-file markdown from raw bytes

Signed-off-by: phernandez <paul@basicmachines.co>

Author: phernandez

src/basic_memory/sync/sync_service.py

@@ -1075,9 +1075,18 @@ async def sync_one_markdown_file(
         """
         logger.debug(f"Parsing markdown file, path: {path}, new: {new}")
 
-        initial_markdown_content = await self.file_service.read_file_content(path)
+        try:
+            initial_markdown_bytes = await self.file_service.read_file_bytes(path)
+        except FileOperationError as exc:
+            # Trigger: FileService wraps binary read failures in FileOperationError.
+            # Why: sync_file() treats bare FileNotFoundError as a deletion race and cleans up the DB row.
+            # Outcome: preserve that contract while still hashing the exact bytes we loaded.
+            if isinstance(exc.__cause__, FileNotFoundError):
+                raise exc.__cause__ from exc
+            raise
+        initial_markdown_content = initial_markdown_bytes.decode("utf-8")
         file_metadata = await self.file_service.get_file_metadata(path)
-        initial_checksum = await compute_checksum(initial_markdown_content)
+        initial_checksum = await compute_checksum(initial_markdown_bytes)
         indexed = await self.batch_indexer.index_markdown_file(
             IndexInputFile(
                 path=path,
@@ -1086,7 +1095,7 @@ async def sync_one_markdown_file(
                 content_type=self.file_service.content_type(path),
                 last_modified=file_metadata.modified_at,
                 created_at=file_metadata.created_at,
-                content=initial_markdown_content.encode("utf-8"),
+                content=initial_markdown_bytes,
             ),
             new=new,
             index_search=False,

tests/sync/test_sync_one_markdown_file.py

@@ -160,7 +160,7 @@ async def test_sync_one_markdown_file_does_not_reread_for_initial_checksum_when_
     test_project,
     monkeypatch,
 ):
-    """Initial checksum comes from the loaded content, not a second storage read."""
+    """Initial checksum comes from the loaded file bytes, not a second storage read."""
     original_content = dedent(
         f"""\
         ---
@@ -174,7 +174,7 @@ async def test_sync_one_markdown_file_does_not_reread_for_initial_checksum_when_
         Body content.
         """
     )
-    _write_markdown(
+    file_path = _write_markdown(
         Path(test_project.path),
         "notes/no-rewrite.md",
         original_content,
@@ -186,7 +186,7 @@ async def test_sync_one_markdown_file_does_not_reread_for_initial_checksum_when_
     result = await sync_service.sync_one_markdown_file("notes/no-rewrite.md", index_search=False)
 
     checksum_spy.assert_not_awaited()
-    assert result.checksum == await compute_checksum(original_content)
+    assert result.checksum == await compute_checksum(file_path.read_bytes())
 
 
 @pytest.mark.asyncio