test(cli): cover update_path and existing-row delete branches

Address reviewer follow-ups on #775:
- Add type annotations to the two CLI helpers (BasicMemoryConfig).
- Note the CLI-only assumption inline at each shutdown_db() call.
- Add two tests that exercise the previously uncovered branches:
  - test_set_local_update_path_when_row_exists hits repo.update_path.
  - test_set_cloud_removes_existing_db_row hits repo.delete on the
    detach helper and asserts the user-visible cleanup message.

Signed-off-by: phernandez <paul@basicmachines.co>

Author: phernandez

src/basic_memory/cli/commands/project.py

@@ -26,7 +26,7 @@
 )
 from basic_memory.cli.commands.command_utils import get_project_info, run_with_cleanup
 from basic_memory.cli.commands.routing import force_routing, validate_routing_flags
-from basic_memory.config import ConfigManager, ProjectEntry, ProjectMode
+from basic_memory.config import BasicMemoryConfig, ConfigManager, ProjectEntry, ProjectMode
 from basic_memory.mcp.async_client import get_client, resolve_configured_workspace
 from basic_memory.mcp.clients import ProjectClient
 from basic_memory.schemas.cloud import (
@@ -838,7 +838,7 @@ async def _move_project():
         raise typer.Exit(1)
 
 
-async def _detach_local_project_row(app_config, name: str) -> bool:
+async def _detach_local_project_row(app_config: BasicMemoryConfig, name: str) -> bool:
     """Drop the project's row from the local index DB.
 
     Trigger: `bm project set-cloud` is making a project cloud-only.
@@ -863,10 +863,12 @@ async def _detach_local_project_row(app_config, name: str) -> bool:
         await repo.delete(existing.id)
         return True
     finally:
+        # CLI-only: safe to tear down the global DB singleton here since
+        # set-cloud/set-local never run inside a long-lived MCP/API server.
         await db.shutdown_db()
 
 
-async def _attach_local_project_row(app_config, name: str, path: str) -> None:
+async def _attach_local_project_row(app_config: BasicMemoryConfig, name: str, path: str) -> None:
     """Ensure the project has a row in the local index DB at the given path.
 
     Trigger: `bm project set-local` is making a previously cloud-only
@@ -901,6 +903,8 @@ async def _attach_local_project_row(app_config, name: str, path: str) -> None:
         if existing.path != path:
             await repo.update_path(existing.id, path)
     finally:
+        # CLI-only: safe to tear down the global DB singleton here since
+        # set-cloud/set-local never run inside a long-lived MCP/API server.
         await db.shutdown_db()
 
 

tests/cli/test_project_set_cloud_local.py

@@ -232,6 +232,28 @@ def test_set_local_clears_workspace_id(self, runner, mock_config, tmp_path):
         assert updated_data["projects"]["research"]["workspace_id"] is None
         assert updated_data["projects"]["research"]["mode"] == "local"
 
+    def test_set_local_update_path_when_row_exists(self, runner, mock_config, tmp_path):
+        """Re-running set-local with a different --local-path must update the
+        existing DB row (covers the repo.update_path() branch in
+        _attach_local_project_row)."""
+        path_a = tmp_path / "research_v1"
+        path_b = tmp_path / "research_v2"
+
+        # First call seeds the DB row at path_a.
+        result_a = runner.invoke(
+            app, ["project", "set-local", "research", "--local-path", str(path_a)]
+        )
+        assert result_a.exit_code == 0
+
+        # Second call must update the existing row's path to path_b.
+        result_b = runner.invoke(
+            app, ["project", "set-local", "research", "--local-path", str(path_b)]
+        )
+        assert result_b.exit_code == 0
+
+        updated = json.loads(mock_config.read_text())
+        assert updated["projects"]["research"]["path"] == path_b.as_posix()
+
 
 class TestSetCloudCutover:
     """Regression tests for #680 — set-cloud as a one-way cutover."""
@@ -244,6 +266,23 @@ def test_set_cloud_clears_path(self, runner, mock_config):
         assert updated["projects"]["research"]["mode"] == "cloud"
         assert updated["projects"]["research"]["path"] == ""
 
+    def test_set_cloud_removes_existing_db_row(self, runner, mock_config, tmp_path):
+        """When set-cloud runs against a project with a DB row, the row must
+        be removed and the user-facing message must mention the cleanup
+        (covers the repo.delete() → return True branch in
+        _detach_local_project_row)."""
+        # Seed a DB row first by going through set-local.
+        research_path = tmp_path / "research"
+        seed = runner.invoke(
+            app, ["project", "set-local", "research", "--local-path", str(research_path)]
+        )
+        assert seed.exit_code == 0
+
+        # Now flip to cloud — _detach_local_project_row should find and drop the row.
+        result = runner.invoke(app, ["project", "set-cloud", "research"])
+        assert result.exit_code == 0
+        assert "local index entry removed" in result.stdout.lower()
+
 
 class TestSetCloudWithWorkspace:
     """Tests for 'bm project set-cloud --workspace' option."""