fix(cli): compare by checksum on overwrite push/pull to match conflict detection

Second code-review finding (PLAUSIBLE): project_diff detects conflicts with
`rclone check` (content/hash), but project_copy used `rclone copy` with its
default size+modtime comparison. On an overwrite strategy (keep-cloud on pull /
keep-local on push), copy could skip a file the diff had flagged as a conflict
when sizes matched and the destination was not older — silently ignoring the
user's explicit choice.

Add `--checksum` to the overwrite copy so the transfer decision uses the same
content basis as detection. New-only mode is unaffected: `--ignore-existing`
skips by existence, so the comparison basis is irrelevant there. project_sync
(the Personal-only mirror) is untouched and keeps its default comparison.

Signed-off-by: phernandez <paul@basicmachines.co>

Author: phernandez

src/basic_memory/cli/commands/cloud/rclone_commands.py

@@ -416,7 +416,14 @@ def project_copy(
     filter_path = filter_path or get_bmignore_filter_path()
 
     source, dest = (remote_path, local_path) if direction == "pull" else (local_path, remote_path)
-    extra_flags = () if overwrite else ("--ignore-existing",)
+    # Overwrite mode compares by checksum so the transfer decision matches
+    # project_diff's content-based conflict detection (rclone check). Without
+    # --checksum, copy's default size+modtime comparison could skip a file the
+    # diff flagged as a conflict (same size, destination not older) — silently
+    # ignoring the user's explicit keep-cloud/keep-local choice. New-only mode
+    # uses --ignore-existing, which skips by existence so the comparison basis
+    # does not matter.
+    extra_flags = ("--checksum",) if overwrite else ("--ignore-existing",)
 
     cmd = _build_transfer_cmd(
         "copy",

tests/test_rclone_commands.py

@@ -662,6 +662,8 @@ def test_project_copy_pull_new_only_adds_ignore_existing(tmp_path):
     assert Path(cmd[3]) == Path("/tmp/research")
     assert "--ignore-existing" in cmd
     assert "--local-no-preallocate" in cmd
+    # new-only skips by existence, so no content comparison is needed
+    assert "--checksum" not in cmd
 
 
 def test_project_copy_pull_overwrite_omits_ignore_existing(tmp_path):
@@ -681,6 +683,8 @@ def test_project_copy_pull_overwrite_omits_ignore_existing(tmp_path):
 
     cmd, _ = runner.calls[0]
     assert "--ignore-existing" not in cmd
+    # overwrite compares by content so it matches hash-based conflict detection
+    assert "--checksum" in cmd
 
 
 def test_project_copy_push_uses_local_as_source(tmp_path):
@@ -771,11 +775,13 @@ def test_project_transfer_keep_cloud_on_pull_overwrites_local(tmp_path):
         filter_path=filter_path,
     )
 
-    # keep-cloud + pull → cloud (source) overwrites local (dest): no --ignore-existing
+    # keep-cloud + pull → cloud (source) overwrites local (dest): no --ignore-existing,
+    # and --checksum so the overwrite decision matches the content-based conflict.
     assert len(runner.calls) == 1
     cmd, _ = runner.calls[0]
     assert cmd[:2] == ["rclone", "copy"]
     assert "--ignore-existing" not in cmd
+    assert "--checksum" in cmd
 
 
 def test_project_transfer_keep_local_on_push_overwrites_cloud(tmp_path):