refactor: convert project_management.py to context manager pattern

Converts 3 project management tool functions to use async with get_client() context manager:

- Changed import from 'client' to 'get_client'

list_memory_projects():
- Wrapped function body at line 43 in async with block
- Indented lines 44-71 inside context manager
- Lists all available projects with session guidance

create_memory_project():
- Wrapped function body at line 95 in async with block
- Indented lines 96-126 inside context manager
- Creates new project with optional default setting

delete_project():
- Wrapped function body at line 150 in async with block
- Indented lines 151-200 inside context manager
- Deletes project with validation and confirmation

All 3 functions passed typecheck with no errors.

Total tools converted: 13/16 (Phase 0.3)

Updated SPEC-16 Phase 0.3 checklist to mark project_management.py as completed.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: phernandez <paul@basicmachines.co>

Author: phernandez

specs/SPEC-16 MCP Cloud Service Consolidation.md

@@ -457,7 +457,7 @@ Convert from `from async_client import client` to `async with get_client() as cl
 - [x] `tools/move_note.py` (34/34 tests passing, 90% coverage)
 - [x] `tools/search.py` (16/16 tests passing, 96% coverage)
 - [x] `tools/recent_activity.py` (4/4 tests passing, 82% coverage)
-- [ ] `tools/project_management.py`
+- [x] `tools/project_management.py` (3 functions: list_memory_projects, create_memory_project, delete_project - typecheck passed)
 - [x] `tools/edit_note.py` (17/17 tests passing)
 - [x] `tools/canvas.py` (5/5 tests passing)
 - [x] `tools/build_context.py` (6/6 tests passing)

src/basic_memory/mcp/tools/project_management.py

@@ -7,7 +7,7 @@
 import os
 from fastmcp import Context
 
-from basic_memory.mcp.async_client import client
+from basic_memory.mcp.async_client import get_client
 from basic_memory.mcp.server import mcp
 from basic_memory.mcp.tools.utils import call_get, call_post, call_delete
 from basic_memory.schemas.project_info import (
@@ -40,34 +40,35 @@ async def list_memory_projects(context: Context | None = None) -> str:
     Example:
         list_memory_projects()
     """
-    if context:  # pragma: no cover
-        await context.info("Listing all available projects")
+    async with get_client() as client:
+        if context:  # pragma: no cover
+            await context.info("Listing all available projects")
 
-    # Check if server is constrained to a specific project
-    constrained_project = os.environ.get("BASIC_MEMORY_MCP_PROJECT")
+        # Check if server is constrained to a specific project
+        constrained_project = os.environ.get("BASIC_MEMORY_MCP_PROJECT")
 
-    # Get projects from API
-    response = await call_get(client, "/projects/projects")
-    project_list = ProjectList.model_validate(response.json())
+        # Get projects from API
+        response = await call_get(client, "/projects/projects")
+        project_list = ProjectList.model_validate(response.json())
 
-    if constrained_project:
-        result = f"Project: {constrained_project}\n\n"
-        result += "Note: This MCP server is constrained to a single project.\n"
-        result += "All operations will automatically use this project."
-    else:
-        # Show all projects with session guidance
-        result = "Available projects:\n"
+        if constrained_project:
+            result = f"Project: {constrained_project}\n\n"
+            result += "Note: This MCP server is constrained to a single project.\n"
+            result += "All operations will automatically use this project."
+        else:
+            # Show all projects with session guidance
+            result = "Available projects:\n"
 
-        for project in project_list.projects:
-            result += f"• {project.name}\n"
+            for project in project_list.projects:
+                result += f"• {project.name}\n"
 
-        result += "\n" + "─" * 40 + "\n"
-        result += "Next: Ask which project to use for this session.\n"
-        result += "Example: 'Which project should I use for this task?'\n\n"
-        result += "Session reminder: Track the selected project for all subsequent operations in this conversation.\n"
-        result += "The user can say 'switch to [project]' to change projects."
+            result += "\n" + "─" * 40 + "\n"
+            result += "Next: Ask which project to use for this session.\n"
+            result += "Example: 'Which project should I use for this task?'\n\n"
+            result += "Session reminder: Track the selected project for all subsequent operations in this conversation.\n"
+            result += "The user can say 'switch to [project]' to change projects."
 
-    return result
+        return result
 
 
 @mcp.tool("create_memory_project")
@@ -91,37 +92,38 @@ async def create_memory_project(
         create_memory_project("my-research", "~/Documents/research")
         create_memory_project("work-notes", "/home/user/work", set_default=True)
     """
-    # Check if server is constrained to a specific project
-    constrained_project = os.environ.get("BASIC_MEMORY_MCP_PROJECT")
-    if constrained_project:
-        return f'# Error\n\nProject creation disabled - MCP server is constrained to project \'{constrained_project}\'.\nUse the CLI to create projects: `basic-memory project add "{project_name}" "{project_path}"`'
-
-    if context:  # pragma: no cover
-        await context.info(f"Creating project: {project_name} at {project_path}")
-
-    # Create the project request
-    project_request = ProjectInfoRequest(
-        name=project_name, path=project_path, set_default=set_default
-    )
+    async with get_client() as client:
+        # Check if server is constrained to a specific project
+        constrained_project = os.environ.get("BASIC_MEMORY_MCP_PROJECT")
+        if constrained_project:
+            return f'# Error\n\nProject creation disabled - MCP server is constrained to project \'{constrained_project}\'.\nUse the CLI to create projects: `basic-memory project add "{project_name}" "{project_path}"`'
+
+        if context:  # pragma: no cover
+            await context.info(f"Creating project: {project_name} at {project_path}")
+
+        # Create the project request
+        project_request = ProjectInfoRequest(
+            name=project_name, path=project_path, set_default=set_default
+        )
 
-    # Call API to create project
-    response = await call_post(client, "/projects/projects", json=project_request.model_dump())
-    status_response = ProjectStatusResponse.model_validate(response.json())
+        # Call API to create project
+        response = await call_post(client, "/projects/projects", json=project_request.model_dump())
+        status_response = ProjectStatusResponse.model_validate(response.json())
 
-    result = f"✓ {status_response.message}\n\n"
+        result = f"✓ {status_response.message}\n\n"
 
-    if status_response.new_project:
-        result += "Project Details:\n"
-        result += f"• Name: {status_response.new_project.name}\n"
-        result += f"• Path: {status_response.new_project.path}\n"
+        if status_response.new_project:
+            result += "Project Details:\n"
+            result += f"• Name: {status_response.new_project.name}\n"
+            result += f"• Path: {status_response.new_project.path}\n"
 
-        if set_default:
-            result += "• Set as default project\n"
+            if set_default:
+                result += "• Set as default project\n"
 
-    result += "\nProject is now available for use in tool calls.\n"
-    result += f"Use '{project_name}' as the project parameter in MCP tool calls.\n"
+        result += "\nProject is now available for use in tool calls.\n"
+        result += f"Use '{project_name}' as the project parameter in MCP tool calls.\n"
 
-    return result
+        return result
 
 
 @mcp.tool()
@@ -145,53 +147,54 @@ async def delete_project(project_name: str, context: Context | None = None) -> s
         This action cannot be undone. The project will need to be re-added
         to access its content through Basic Memory again.
     """
-    # Check if server is constrained to a specific project
-    constrained_project = os.environ.get("BASIC_MEMORY_MCP_PROJECT")
-    if constrained_project:
-        return f"# Error\n\nProject deletion disabled - MCP server is constrained to project '{constrained_project}'.\nUse the CLI to delete projects: `basic-memory project remove \"{project_name}\"`"
-
-    if context:  # pragma: no cover
-        await context.info(f"Deleting project: {project_name}")
-
-    # Get project info before deletion to validate it exists
-    response = await call_get(client, "/projects/projects")
-    project_list = ProjectList.model_validate(response.json())
-
-    # Find the project by name (case-insensitive) or permalink - same logic as switch_project
-    project_permalink = generate_permalink(project_name)
-    target_project = None
-    for p in project_list.projects:
-        # Match by permalink (handles case-insensitive input)
-        if p.permalink == project_permalink:
-            target_project = p
-            break
-        # Also match by name comparison (case-insensitive)
-        if p.name.lower() == project_name.lower():
-            target_project = p
-            break
-
-    if not target_project:
-        available_projects = [p.name for p in project_list.projects]
-        raise ValueError(
-            f"Project '{project_name}' not found. Available projects: {', '.join(available_projects)}"
-        )
-
-    # Call API to delete project using URL encoding for special characters
-    from urllib.parse import quote
-
-    encoded_name = quote(target_project.name, safe="")
-    response = await call_delete(client, f"/projects/{encoded_name}")
-    status_response = ProjectStatusResponse.model_validate(response.json())
-
-    result = f"✓ {status_response.message}\n\n"
-
-    if status_response.old_project:
-        result += "Removed project details:\n"
-        result += f"• Name: {status_response.old_project.name}\n"
-        if hasattr(status_response.old_project, "path"):
-            result += f"• Path: {status_response.old_project.path}\n"
-
-    result += "Files remain on disk but project is no longer tracked by Basic Memory.\n"
-    result += "Re-add the project to access its content again.\n"
-
-    return result
+    async with get_client() as client:
+        # Check if server is constrained to a specific project
+        constrained_project = os.environ.get("BASIC_MEMORY_MCP_PROJECT")
+        if constrained_project:
+            return f"# Error\n\nProject deletion disabled - MCP server is constrained to project '{constrained_project}'.\nUse the CLI to delete projects: `basic-memory project remove \"{project_name}\"`"
+
+        if context:  # pragma: no cover
+            await context.info(f"Deleting project: {project_name}")
+
+        # Get project info before deletion to validate it exists
+        response = await call_get(client, "/projects/projects")
+        project_list = ProjectList.model_validate(response.json())
+
+        # Find the project by name (case-insensitive) or permalink - same logic as switch_project
+        project_permalink = generate_permalink(project_name)
+        target_project = None
+        for p in project_list.projects:
+            # Match by permalink (handles case-insensitive input)
+            if p.permalink == project_permalink:
+                target_project = p
+                break
+            # Also match by name comparison (case-insensitive)
+            if p.name.lower() == project_name.lower():
+                target_project = p
+                break
+
+        if not target_project:
+            available_projects = [p.name for p in project_list.projects]
+            raise ValueError(
+                f"Project '{project_name}' not found. Available projects: {', '.join(available_projects)}"
+            )
+
+        # Call API to delete project using URL encoding for special characters
+        from urllib.parse import quote
+
+        encoded_name = quote(target_project.name, safe="")
+        response = await call_delete(client, f"/projects/{encoded_name}")
+        status_response = ProjectStatusResponse.model_validate(response.json())
+
+        result = f"✓ {status_response.message}\n\n"
+
+        if status_response.old_project:
+            result += "Removed project details:\n"
+            result += f"• Name: {status_response.old_project.name}\n"
+            if hasattr(status_response.old_project, "path"):
+                result += f"• Path: {status_response.old_project.path}\n"
+
+        result += "Files remain on disk but project is no longer tracked by Basic Memory.\n"
+        result += "Re-add the project to access its content again.\n"
+
+        return result