Skip to content

Commit b225857

Browse files
phernandezclaude
andcommitted
refactor: Move generate_permalink import to top-level in deps.py
Addresses PR review feedback to follow project code style guidelines by moving inline imports to top-level imports for better consistency. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 87df04a commit b225857

2 files changed

Lines changed: 2 additions & 8 deletions

File tree

src/basic_memory/deps.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
from basic_memory.services.link_resolver import LinkResolver
3434
from basic_memory.services.search_service import SearchService
3535
from basic_memory.sync import SyncService
36+
from basic_memory.utils import generate_permalink
3637

3738

3839
def get_app_config() -> BasicMemoryConfig: # pragma: no cover
@@ -61,8 +62,6 @@ async def get_project_config(
6162
Raises:
6263
HTTPException: If project is not found
6364
"""
64-
from basic_memory.utils import generate_permalink
65-
6665
# Convert project name to permalink for lookup
6766
project_permalink = generate_permalink(str(project))
6867
project_obj = await project_repository.get_by_permalink(project_permalink)
@@ -150,8 +149,6 @@ async def get_project_id(
150149
Raises:
151150
HTTPException: If project is not found
152151
"""
153-
from basic_memory.utils import generate_permalink
154-
155152
# Convert project name to permalink for lookup
156153
project_permalink = generate_permalink(str(project))
157154
project_obj = await project_repository.get_by_permalink(project_permalink)

tests/test_deps.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import pytest_asyncio
88
from fastapi import HTTPException
99

10-
from basic_memory.config import ProjectConfig
1110
from basic_memory.deps import get_project_config, get_project_id
1211
from basic_memory.models.project import Project
1312
from basic_memory.repository.project_repository import ProjectRepository
@@ -175,9 +174,7 @@ async def test_get_project_id_fallback_to_name(
175174
# The test_project fixture has name "test-project" and permalink "test-project"
176175
# Since both are the same, we can't easily test the fallback with existing fixtures
177176
# So this test just verifies the normal path works with test_project
178-
project_id = await get_project_id(
179-
project_repository=project_repository, project="test-project"
180-
)
177+
project_id = await get_project_id(project_repository=project_repository, project="test-project")
181178

182179
assert project_id == test_project.id
183180

0 commit comments

Comments
 (0)