test(core): assert portable note paths and newlines

Signed-off-by: phernandez <paul@basicmachines.co>

Author: phernandez

tests/mcp/test_tool_read_note.py

@@ -9,7 +9,6 @@
 from basic_memory import db
 from basic_memory.mcp.tools import write_note, read_note
 from basic_memory.mcp.tools.read_note import _parse_opening_frontmatter
-from basic_memory.utils import normalize_newlines
 from tests.mcp.conftest import ContextState, ctx
 
 
@@ -611,7 +610,7 @@ async def test_note_unicode_content(app, test_project):
 
     # Read back should preserve unicode
     result = await read_note("test/unicode-test", project=test_project.name)
-    assert normalize_newlines(content) in result
+    assert content in result
 
 
 @pytest.mark.asyncio

tests/mcp/test_tool_write_note.py

@@ -10,7 +10,6 @@
 from basic_memory.mcp.tools import write_note, read_note, delete_note
 from basic_memory.mcp.tools.write_note import _compose_workspace_project_route
 from basic_memory.repository.relation_repository import RelationRepository
-from basic_memory.utils import normalize_newlines
 
 
 # ---------------------------------------------------------------------------
@@ -144,7 +143,7 @@ async def test_write_note(app, test_project):
 
     # Try reading it back via permalink
     content = await read_note("test/test-note", project=test_project.name)
-    expected = normalize_newlines(
+    expected = (
         dedent("""
         ---
         title: Test Note
@@ -179,7 +178,7 @@ async def test_write_note_no_tags(app, test_project):
     assert f"[Session: Using project '{test_project.name}']" in result
     # Should be able to read it back
     content = await read_note("test/simple-note", project=test_project.name)
-    expected = normalize_newlines(
+    expected = (
         dedent("""
         ---
         title: Simple Note
@@ -241,9 +240,8 @@ async def test_write_note_update_existing(app, test_project):
     # Try reading it back
     content = await read_note("test/test-note", project=test_project.name)
     assert (
-        normalize_newlines(
-            dedent(
-                """
+        dedent(
+            """
         ---
         title: Test Note
         type: note
@@ -256,10 +254,9 @@ async def test_write_note_update_existing(app, test_project):
         # Test
         This is an updated note
         """
-            )
-            .format(permalink=f"{test_project.name}/test/test-note")
-            .strip()
         )
+        .format(permalink=f"{test_project.name}/test/test-note")
+        .strip()
         == content
     )
 
@@ -555,9 +552,8 @@ async def test_write_note_preserves_content_frontmatter(app, test_project):
     # Try reading it back via permalink
     content = await read_note("test/test-note", project=test_project.name)
     assert (
-        normalize_newlines(
-            dedent(
-                """
+        dedent(
+            """
             ---
             title: Test Note
             type: note
@@ -573,10 +569,9 @@ async def test_write_note_preserves_content_frontmatter(app, test_project):
 
             This is a test note
             """
-            )
-            .format(permalink=f"{test_project.name}/test/test-note")
-            .strip()
         )
+        .format(permalink=f"{test_project.name}/test/test-note")
+        .strip()
         in content
     )
 
@@ -711,7 +706,7 @@ async def test_write_note_with_custom_note_type(app, test_project):
 
     # Verify the note type is correctly set in the frontmatter
     content = await read_note("guides/test-guide", project=test_project.name)
-    expected = normalize_newlines(
+    expected = (
         dedent("""
         ---
         title: Test Guide

tests/schemas/test_schemas.py

@@ -1,6 +1,5 @@
 """Tests for Pydantic schema validation and conversion."""
 
-import os
 import pytest
 from datetime import datetime, timedelta
 from pydantic import ValidationError, BaseModel
@@ -21,7 +20,7 @@ def test_entity_project_name():
     """Test creating EntityIn with minimal required fields."""
     data = {"title": "Test Entity", "directory": "test", "note_type": "knowledge"}
     entity = Entity.model_validate(data)
-    assert entity.file_path == os.path.join("test", "Test Entity.md")
+    assert entity.file_path == "test/Test Entity.md"
     assert entity.permalink == "test/test-entity"
     assert entity.note_type == "knowledge"
 
@@ -30,7 +29,7 @@ def test_entity_project_id():
     """Test creating EntityIn with minimal required fields."""
     data = {"project": 2, "title": "Test Entity", "directory": "test", "note_type": "knowledge"}
     entity = Entity.model_validate(data)
-    assert entity.file_path == os.path.join("test", "Test Entity.md")
+    assert entity.file_path == "test/Test Entity.md"
     assert entity.permalink == "test/test-entity"
     assert entity.note_type == "knowledge"
 
@@ -44,7 +43,7 @@ def test_entity_non_markdown():
         "content_type": "text/plain",
     }
     entity = Entity.model_validate(data)
-    assert entity.file_path == os.path.join("test", "Test Entity.txt")
+    assert entity.file_path == "test/Test Entity.txt"
     assert entity.permalink == "test/test-entity"
     assert entity.note_type == "file"