fix: Fix failing watch service edge case tests

- Fix tests to pass absolute paths to handle_changes instead of relative paths
- Add directory filtering to deletion processing to skip directories without entities
- All watch service edge case tests now pass

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Joe P <joe@basicmemory.com>

Author: jope-bm

src/basic_memory/sync/watch_service.py

@@ -296,6 +296,16 @@ async def handle_changes(self, project: Project, changes: Set[FileChange]) -> No
                     processed.add(path)
                     modify_count += 1
                 else:
+                    # Check if this was a directory - skip if so
+                    # (we can't tell if the deleted path was a directory since it no longer exists,
+                    # so we check if there's an entity in the database for it)
+                    entity = await sync_service.entity_repository.get_by_file_path(path)
+                    if entity is None:
+                        # No entity means this was likely a directory - skip it
+                        logger.debug(f"Skipping deleted path with no entity (likely directory), path={path}")
+                        processed.add(path)
+                        continue
+                    
                     # File truly deleted
                     logger.debug("Processing deleted file", path=path)
                     await sync_service.handle_delete(path)

tests/sync/test_watch_service_edge_cases.py

@@ -1,6 +1,5 @@
 """Test edge cases in the WatchService."""
 
-from pathlib import Path
 from unittest.mock import patch
 
 import pytest
@@ -103,9 +102,8 @@ async def test_handle_vim_atomic_write_delete_still_exists(watch_service, projec
     test_file.write_text(modified_content)
 
     # Setup DELETE event even though file still exists (vim's atomic write behavior)
-    # Use relative path like the real watch service would
-    relative_path = str(test_file.relative_to(project_dir))
-    changes = {(Change.deleted, relative_path)}
+    # Use absolute path like the real watch service would
+    changes = {(Change.deleted, str(test_file))}
 
     # Handle the change
     await watch_service.handle_changes(test_project, changes)
@@ -155,12 +153,10 @@ async def test_handle_true_deletion_vs_vim_atomic(watch_service, project_config,
     delete_file.unlink()
 
     # Setup DELETE events for both files
-    # Use relative paths like the real watch service would
-    atomic_relative = str(atomic_file.relative_to(project_dir))
-    delete_relative = str(delete_file.relative_to(project_dir))
+    # Use absolute paths like the real watch service would
     changes = {
-        (Change.deleted, atomic_relative),  # File still exists - atomic write
-        (Change.deleted, delete_relative),  # File deleted - true deletion
+        (Change.deleted, str(atomic_file)),  # File still exists - atomic write
+        (Change.deleted, str(delete_file)),  # File deleted - true deletion
     }
 
     # Handle the changes
@@ -235,9 +231,8 @@ async def test_handle_vim_atomic_write_markdown_with_relations(watch_service, pr
     main_file.write_text(modified_content)
 
     # Setup DELETE event (vim atomic write)
-    # Use relative path like the real watch service would
-    relative_path = str(main_file.relative_to(project_dir))
-    changes = {(Change.deleted, relative_path)}
+    # Use absolute path like the real watch service would
+    changes = {(Change.deleted, str(main_file))}
 
     # Handle the change
     await watch_service.handle_changes(test_project, changes)
@@ -267,9 +262,8 @@ async def test_handle_vim_atomic_write_directory_path_ignored(watch_service, pro
     test_dir.mkdir()
 
     # Setup DELETE event for directory (should be ignored)
-    # Use relative path like the real watch service would
-    relative_path = str(test_dir.relative_to(project_dir))
-    changes = {(Change.deleted, relative_path)}
+    # Use absolute path like the real watch service would
+    changes = {(Change.deleted, str(test_dir))}
 
     # Handle the change - should not cause errors
     await watch_service.handle_changes(test_project, changes)