fix: Ensure datetime serialization includes timezone info for RFC 3339 compliance#267
Closed
jope-bm wants to merge 2 commits into
Closed
fix: Ensure datetime serialization includes timezone info for RFC 3339 compliance#267jope-bm wants to merge 2 commits into
jope-bm wants to merge 2 commits into
Conversation
…9 compliance Add field_serializer methods to all datetime fields in memory schemas to ensure proper timezone-aware datetime serialization. This fixes validation errors in MCP tools like build_context where datetime strings were missing timezone information. - Added ensure_timezone_aware utility function - Updated EntitySummary, RelationSummary, ObservationSummary, MemoryMetadata - All datetime fields now serialize with timezone suffix (Z or +00:00) - Handles both timezone-aware and naive datetimes by converting to UTC Fixes #253 Co-authored-by: jope-bm <jope-bm@users.noreply.github.com>
The datetime fix test was only for development verification.
phernandez
approved these changes
Aug 22, 2025
Member
phernandez
left a comment
There was a problem hiding this comment.
I thought pydandic did this for us?
Contributor
Author
If the source datetime is naive (no tzinfo), it is serialized without Z or timezone. Which, of course, makes sense. So maybe the real issue is that build_context is creating datetimes without timezone? I'm not sure how we'd be getting an ISO string without tzinfo otherwise. |
Member
|
🤷🏽 it could also be a platform thing, or some weird mcp tool thing. Whatever it takes. |
Contributor
Author
|
@phernandez This is what Claude tells me: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add field_serializer methods to all datetime fields in memory schemas to ensure proper timezone-aware datetime serialization. This fixes validation errors in MCP tools like build_context where datetime strings were missing timezone information.
Fixes #253
Generated with Claude Code