Skip to content

fix: preserve Chinese characters in permalinks #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phernandez merged 2 commits into from
Apr 17, 2025
Merged

fix: preserve Chinese characters in permalinks #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a578b2
Fix: preserve Chinese characters in permalinks
andyxinweiminicloud Apr 16, 2025
1bfe936
Merge branch 'main' into fix-chinese-permalink
phernandez Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/basic_memory/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def generate_permalink(file_path: Union[Path, str, PathLike]) -> str:

Returns:
Normalized permalink that matches validation rules. Converts spaces and underscores
to hyphens for consistency.
to hyphens for consistency. Preserves non-ASCII characters like Chinese.

Examples:
>>> generate_permalink("docs/My Feature.md")
Expand All @@ -44,35 +44,35 @@ def generate_permalink(file_path: Union[Path, str, PathLike]) -> str:
'specs/api-v2'
>>> generate_permalink("design/unified_model_refactor.md")
'design/unified-model-refactor'
>>> generate_permalink("中文/测试文档.md")
'中文/测试文档'
"""
# Convert Path to string if needed
path_str = str(file_path)

# Remove extension
base = os.path.splitext(path_str)[0]

# Transliterate unicode to ascii
ascii_text = unidecode(base)

# Insert dash between camelCase
ascii_text = re.sub(r"([a-z0-9])([A-Z])", r"\1-\2", ascii_text)
base_with_dashes = re.sub(r"([a-z0-9])([A-Z])", r"\1-\2", base)

# Convert to lowercase
lower_text = ascii_text.lower()
# Convert ASCII letters to lowercase, preserve non-ASCII characters
lower_text = "".join(c.lower() if c.isascii() and c.isalpha() else c for c in base_with_dashes)

# replace underscores with hyphens
# Replace underscores with hyphens
text_with_hyphens = lower_text.replace("_", "-")

# Replace remaining invalid chars with hyphens
clean_text = re.sub(r"[^a-z0-9/\-]", "-", text_with_hyphens)
# Replace spaces and unsafe ASCII characters with hyphens, but preserve non-ASCII characters
# Include common Chinese character ranges and other non-ASCII characters
clean_text = re.sub(r"[^a-z0-9\u4e00-\u9fff\u3000-\u303f\u3400-\u4dbf/\-]", "-", text_with_hyphens)

# Collapse multiple hyphens
clean_text = re.sub(r"-+", "-", clean_text)

# Clean each path segment
segments = clean_text.split("/")
clean_segments = [s.strip("-") for s in segments]

return "/".join(clean_segments)


Expand Down
Loading