fix(plugins): make Claude hook tests portable on Windows#1055
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
|
@codex review |
|
recheck |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: phernandez <paul@basicmachines.co>
|
@codex review |
|
recheck |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d319bc2e4c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: phernandez <paul@basicmachines.co>
|
recheck |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e94041fca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: phernandez <paul@basicmachines.co>
phernandez
changed the title
|
@codex review |
|
recheck |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be19ae794c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: phernandez <paul@basicmachines.co>
|
@codex review |
|
recheck |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Why
The Bash hook regression tests added in #924 pass on macOS and Linux, but fail in the Windows unit job because
subprocess.run(["bash", ...])resolves to the Windows WSL launcher. GitHub's Windows runner has no WSL distribution installed, so the tests exit before exercising the scripts. After selecting Git Bash, native Windows Python also exposed two harness assumptions: it resolves the home directory throughUSERPROFILE, and it cannot execute an extensionless shebang shim directly.What Changed
bin/bash.exefrom the installedgit.exe.BM_BINcommand override as the Codex hooks.HOMEandUSERPROFILEin the hook harness.Testing
uv run pytest -q tests/test_claude_plugin_hooks.py— 6 passed.just fast-check— passed with the repository's existing Python 3.14 asyncio deprecation diagnostics.just package-check-claude-code— passed.git diff --check— passed.Risks / Follow-ups
The remaining validation is the Windows GitHub Actions unit job that exposed both failures. Once this lands, queued PRs should be rebased so their Windows jobs include the corrected harness.