Conversation
| self.save_config(config) | ||
| return config | ||
| logger.exception(f"Failed to load config: {e}") | ||
| raise e |
There was a problem hiding this comment.
this fixes the issue with config file being overwritten by default values. Just propagate the error.
| diagnose=True, | ||
| enqueue=True, | ||
| colorize=False, | ||
| ) |
There was a problem hiding this comment.
re-enable logging to log file
Signed-off-by: Joe P <joe@basicmemory.com>
Signed-off-by: Joe P <joe@basicmemory.com>
Signed-off-by: Joe P <joe@basicmemory.com>
jope-bm
force-pushed
the
fix/basic-memory-home-env-var-not-respected
branch
from
73009c7 to
01ece8e
Compare
phernandez
left a comment
phernandez
left a comment
There was a problem hiding this comment.
One big thing that goes along with this is that now that we have updated the config, we need to stop watching the old project dir and start watching the new one. I think that's outside the scope of this PR, just saying.
There is a PR where I half implemented this, but I didn't love it #176
| ValueError: If the project doesn't exist or repository isn't initialized | ||
| """ | ||
| if not self.repository: | ||
| raise ValueError("Repository is required for move_project") |
There was a problem hiding this comment.
This looks like Claude doing goldplating BS. We should always have a repository. But whatever.
There was a problem hiding this comment.
Yeah seems overkill. All the other service method have it, so that's probably why Claude did it here.
👍 |
2 participants
Addresses #219
This PR adds a new CLI command to move a project's location. The BASIC_MEMORY_HOME envvar is only used to set the project directory at startup if the
mainproject does not already exist.Command Syntax:
This command will lookup a project's path in the config and update it there, then sync the new path in the BM database. It will not move your project's files and sub-directories. You will need to do that after the tool has run. BM will then create new notes, read notes, etc for the projects in the new location.
Additionally, this PR