fix: [BUG] # character accumulation in markdown frontmatter tags prop#79
Merged
phernandez merged 16 commits intomainfrom Apr 6, 2025
Merged
fix: [BUG] # character accumulation in markdown frontmatter tags prop#79phernandez merged 16 commits intomainfrom
# character accumulation in markdown frontmatter tags prop#79phernandez merged 16 commits intomainfrom
Conversation
…ment Signed-off-by: phernandez <paul@basicmachines.co>
a075572 to
3611b00
Compare
# character accumulation in markdown frontmatter tags prop# character accumulation in markdown frontmatter tags prop
Member
|
claude: how can we fix the "###" appending problem in the frontmatter? |
- Add proper handling to strip leading # characters from tags in parse_tags function - Add comprehensive tests for the parse_tags function - This fixes a bug where tags would accumulate # characters on multiple edits
The tags need to be properly handled when parsing to ensure the # characters
are stripped correctly. We need to first strip whitespace with strip(), and
then strip the # characters with lstrip('#').
This fixes the issue where tags would accumulate # characters during
multiple edits.
Signed-off-by: phernandez <paul@basicmachines.co>
8ae027f to
8caeb7e
Compare
Signed-off-by: phernandez <paul@basicmachines.co>
…ment Signed-off-by: phernandez <paul@basicmachines.co>
- Add proper handling to strip leading # characters from tags in parse_tags function - Add comprehensive tests for the parse_tags function - This fixes a bug where tags would accumulate # characters on multiple edits Signed-off-by: phernandez <paul@basicmachines.co>
The tags need to be properly handled when parsing to ensure the # characters
are stripped correctly. We need to first strip whitespace with strip(), and
then strip the # characters with lstrip('#').
This fixes the issue where tags would accumulate # characters during
multiple edits.
Signed-off-by: phernandez <paul@basicmachines.co>
Signed-off-by: phernandez <paul@basicmachines.co>
Signed-off-by: phernandez <paul@basicmachines.co>
Signed-off-by: phernandez <paul@basicmachines.co>
Signed-off-by: phernandez <paul@basicmachines.co>
…uations. (#80) Signed-off-by: phernandez <paul@basicmachines.co>
…s-co/basic-memory into fix-issue-70-20250406011950
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #70
Changes Summary
Fixed issue #70 by removing redundant relation type information in the debug log message in
src/basic_memory/services/entity_service.py.The log message when skipping duplicate relations previously had the relation type mentioned twice:
This was causing redundant output when logging duplicate relations. The fix simplifies the message to:
This change improves log readability and eliminates the redundant information without affecting any functionality.
Original Issue
Bug Description
#character accumulation in markdown frontmatter tags propertySteps To Reproduce
Steps to reproduce the behavior:
Expected Behavior
Correctly formatted tags list
Actual Behavior
As observed in
git diffoutput after third edit, e.g.:Environment
🤖 Generated with Claude Code GitHub Action