fix(mcp): restore write_note overwrite schema for external clients (#818)#841
Open
rudi193-cmd wants to merge 1 commit into
Open
fix(mcp): restore write_note overwrite schema for external clients (#818)#841rudi193-cmd wants to merge 1 commit into
rudi193-cmd wants to merge 1 commit into
Conversation
…asicmachines-co#818) AliasChoices on optional bool | None made FastMCP emit a null-only JSON schema, so Claude Code and other external MCP clients dropped overwrite=true. Revert to a plain parameter; directory aliases unchanged. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: rudi193-cmd <rudi193@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
rudi193-cmd
force-pushed
the
fix/write-note-overwrite-schema
branch
from
852c5fa to
2514015
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
overwriteonwrite_notefromAnnotated[..., Field(validation_alias=AliasChoices(...))]to plainbool | None = None.AliasChoiceson optionalbool | Nonemade FastMCP emit a JSON schema where external MCP clients (e.g. Claude Code) sawoverwriteas null-only;overwrite=truewas silently dropped. FastMCP's PythonClientstill passed tests because it validates via Pydantic directly.booleanforoverwrite.directoryaliases (folder/dir/path) are unchanged.Test plan
pytest test-int/mcp/test_param_aliases_integration.py::test_write_note_overwrite_canonical_via_mcppytest test-int/mcp/test_param_aliases_integration.py::test_aliases_not_advertised_in_schemaFixes #818
Made with Cursor