fix(cli): ignore CancelledError in background task done callback (#839)#842
Open
rudi193-cmd wants to merge 1 commit into
Open
fix(cli): ignore CancelledError in background task done callback (#839)#842rudi193-cmd wants to merge 1 commit into
rudi193-cmd wants to merge 1 commit into
Conversation
…icmachines-co#839) CLI teardown cancels pending sync_entity_vectors tasks; _log_task_failure treated that as an unhandled callback exception because CancelledError is a BaseException. Skip cancelled tasks and add regression tests. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: rudi193-cmd <rudi193@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
rudi193-cmd
force-pushed
the
fix/task-cancelled-callback
branch
from
8c0046f to
d00d9d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After a successful
basic-memory tool write-note, stderr could show anasyncio.CancelledErrortraceback even though exit code was 0 and stdout JSON was correct.LocalTaskSchedulerattaches_log_task_failureto backgroundsync_entity_vectorstasks. On CLI teardown the task is cancelled;completed.result()raisesCancelledError, which is aBaseException(not caught byexcept Exception).Fix
completed.cancelled()asyncio.CancelledErrortests/deps/test_task_failure_callback.pyTest plan
pytest tests/deps/test_task_failure_callback.pyFixes #839
Made with Cursor