fix: align schema tool interfaces with BM MCP response format

SchemaInferResult and SchemaDiffResult interfaces used 'field' and
'frequency' but BM MCP returns 'name' and 'percentage'. This caused
NaN% and undefined in schema-infer and schema-diff tool output.

Updated interfaces, formatters, and tests to match actual BM response.

Author: bm-clawd

bm-client.ts

@@ -121,9 +121,14 @@ export interface SchemaInferResult {
   entity_type: string
   notes_analyzed: number
   field_frequencies: Array<{
-    field: string
-    frequency: number
+    name: string
+    percentage: number
     count: number
+    total: number
+    source: string
+    sample_values?: string[]
+    is_array?: boolean
+    target_type?: string | null
   }>
   suggested_schema: Record<string, unknown>
   suggested_required: string[]
@@ -134,8 +139,8 @@ export interface SchemaInferResult {
 export interface SchemaDiffResult {
   entity_type: string
   schema_found: boolean
-  new_fields: Array<{ field: string; frequency: number }>
-  dropped_fields: Array<{ field: string; declared_in: string }>
+  new_fields: Array<{ name: string; source: string; count: number; total: number; percentage: number }>
+  dropped_fields: Array<{ name: string; source: string; declared_in?: string }>
   cardinality_changes: string[]
 }
 

tools/schema-diff.test.ts

@@ -41,8 +41,8 @@ describe("schema-diff tool", () => {
       ;(mockClient.schemaDiff as jest.MockedFunction<any>).mockResolvedValue({
         entity_type: "person",
         schema_found: true,
-        new_fields: [{ field: "phone", frequency: 0.6 }],
-        dropped_fields: [{ field: "fax", declared_in: "schema" }],
+        new_fields: [{ name: "phone", source: "observation", count: 6, total: 10, percentage: 0.6 }],
+        dropped_fields: [{ name: "fax", source: "observation", declared_in: "schema" }],
         cardinality_changes: [],
       })
 

tools/schema-diff.ts

@@ -62,15 +62,15 @@ export function registerSchemaDiffTool(
               lines.push("", "### New Fields (in notes, not in schema)")
               for (const f of result.new_fields) {
                 lines.push(
-                  `- **${f.field}** — ${(f.frequency * 100).toFixed(0)}% of notes`,
+                  `- **${f.name}** — ${(f.percentage * 100).toFixed(0)}% of notes`,
                 )
               }
             }
 
             if (result.dropped_fields.length > 0) {
               lines.push("", "### Dropped Fields (in schema, not in notes)")
               for (const f of result.dropped_fields) {
-                lines.push(`- **${f.field}** — declared in ${f.declared_in}`)
+                lines.push(`- **${f.name}** — declared in ${f.declared_in}`)
               }
             }
 

tools/schema-infer.test.ts

@@ -42,8 +42,8 @@ describe("schema-infer tool", () => {
         entity_type: "person",
         notes_analyzed: 12,
         field_frequencies: [
-          { field: "name", frequency: 1.0, count: 12 },
-          { field: "email", frequency: 0.75, count: 9 },
+          { name: "name", percentage: 1.0, count: 12, total: 12, source: "observation" },
+          { name: "email", percentage: 0.75, count: 9, total: 12, source: "observation" },
         ],
         suggested_schema: { name: "string", "email?": "string" },
         suggested_required: ["name"],

tools/schema-infer.ts

@@ -66,7 +66,7 @@ export function registerSchemaInferTool(
             lines.push("", "### Field Frequencies")
             for (const f of result.field_frequencies) {
               lines.push(
-                `- **${f.field}** — ${(f.frequency * 100).toFixed(0)}% (${f.count} notes)`,
+                `- **${f.name}** — ${(f.percentage * 100).toFixed(0)}% (${f.count} notes)`,
               )
             }
           }