Register service actions in async_setup for Bronze tier compliance

[ademuri]

• Move 'apply' and 'set_manual_control' service registration from async_setup_entry to async_setup.
• Move service handlers to module-level functions in switch.py.
• Update apply_service_schema to support dynamic defaults for transition duration.
• Clean up related unused imports and fix Python 3.10 syntax compatibility.

Addresses a point from #1195.

[basnijholt]

Awesome! Thanks for all the PRs. There seems to be one failing job still (pre-commit).

[basnijholt]

@all-contributors please add @ademuri for code

[allcontributors]

@basnijholt

I've put up a pull request to add @ademuri! 🎉

[basnijholt]

Thanks for working on this!

Python 3.12 type syntax

The change from type AdaptiveSwitches = ... to AdaptiveSwitches = ... isn't needed - our earliest supported HA version (2024.12.5) requires Python 3.12, and the type statement was introduced in Python 3.12 (PEP 695). Why did you make this change?

[basnijholt]

Why?

[ademuri]

This was a result of running ruff check . --fix. Looks like the Ruff target Python version is currently set to 3.10.

I ran Ruff because Home Assistant core requires it, but I don't see it in either of the READMEs. Should it be used?

[ademuri]

I reverted this change.

[basnijholt]

Why did you make it a required attribute?

[ademuri]

This was unintentional, I think related to initial_transition not being present for apply_service_schema. The default is now None in the schema - will that cause any issues?

[basnijholt]

Sorry it took me so long to get to this. I've been a bit overwhelmed by the number of AI-assisted PRs opened here recently, and I've also been spending nearly every spare hour on my biggest project so far, MindRoom.

I'm very supportive of using AI for coding, but many of these PRs still need careful human review because even plausible-looking changes can introduce subtle breakage. That backlog made me postpone reviewing them for a while.

I've now done a batch review with Codex / GPT-5.5 (xhigh). This comment is AI-assisted, but I've reviewed it before posting.

The Bronze-tier service-action direction is useful, but this branch is conflict-heavy against current main and touches setup, service registration, docs, and tests.

I do not want to merge or deeply review this version as-is because the integration setup path has changed since this branch was opened. Please rebase onto current main, keep the service-registration change as small as possible, and make sure the service/action tests pass on the current HA matrix.

[basnijholt]

Follow-up from a deeper Codex / GPT-5.5 (xhigh) pass.

The move toward global service-action registration makes sense for Bronze compliance, but the new change_switch_settings service schema still treats entity_id as optional even though the handler cannot do anything without either entity_id or lights:

vol.Optional(CONF_ENTITY_ID): cv.entity_ids

For change_switch_settings, lights is deliberately skipped because CONF_LIGHTS is not changeable after init, so a call without entity_id only fails later inside _switches_from_service_call() with a ServiceValidationError. For a service/action UI, it would be cleaner and safer to make entity_id required in the schema for this service, so invalid calls are rejected at validation time and the UI communicates the requirement.

Please make the target requirement explicit in change_switch_settings_schema() and add a test that the service schema rejects missing targets before handler logic runs.