Replace hardcoded URLs in strings.json and translation files.#1422
Replace hardcoded URLs in strings.json and translation files.#1422ademuri wants to merge 1 commit into
Conversation
This replaces them with placeholders ({webapp_url} and {docs_url}), and
updates config_flow.py to inject these values.
This fixes the "Validate with hassfest" CI action.
florianhorner
left a comment
florianhorner
left a comment
There was a problem hiding this comment.
Clean change — consistent URL placeholder pattern across all translation files. LGTM.
florianhorner
left a comment
florianhorner
left a comment
There was a problem hiding this comment.
Clean and consistent — replaces hardcoded URLs with proper constants. LGTM.
…te is superset)
|
Sorry it took me so long to get to this. I've been a bit overwhelmed by the number of AI-assisted PRs opened here recently, and I've also been spending nearly every spare hour on my biggest project so far, MindRoom. I'm very supportive of using AI for coding, but many of these PRs still need careful human review because even plausible-looking changes can introduce subtle breakage. That backlog made me postpone reviewing them for a while. I've now done a batch review with Codex / GPT-5.5 (xhigh). This comment is AI-assisted, but I've reviewed it before posting. The placeholder approach for the docs/webapp URLs looks fine to me, and I do not see a direct issue in the string/config-flow diff. However, the PR currently has failing checks, including the dev pytest job and Docker builds. Please rebase and get CI green before merging. If the failures are unrelated to this PR, a fresh run after rebasing should make that clear. |
3 participants
This replaces them with placeholders (
{webapp_url}and{docs_url}), and updatesconfig_flow.pyto inject these values.This fixes the "Validate with hassfest" CI action.