Add periodic_callable#209
Open
basnijholt wants to merge 11 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 74.54% 74.40% -0.15%
==========================================
Files 22 22
Lines 2742 2754 +12
==========================================
+ Hits 2044 2049 +5
- Misses 698 705 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Great! The only change I would add would be to pass the learner's "fname" along with the learner itself (like 'to_dataframe' takes) |
The first argument is the 'fname' of the learner, and the second argument is the learner itself. The fname is needed to use as a base, if the periodic callable will save some additional data.
basnijholt
commented
Mar 15, 2024
Owner
Author
basnijholt
left a comment
basnijholt
left a comment
There was a problem hiding this comment.
Looks good @jbweston! Go ahead and merge if you are happy with the implementation and it works for your use-case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jbweston, what about this? Closes #206.
I haven't really tested it but I suppose you can first see it this matches your use-case.
edit: I tested it and now it works