Skip to content

Commit fd6eba9

Browse files
committed
fix: platform-split onnxruntime pins and skip rag/memory on 3.14 CI
Force onnxruntime>=1.24.1 on non-Windows so the resolver picks a version with Python 3.14 wheels. On Windows, markitdown caps onnxruntime<=1.20.1 (microsoft/markitdown#1551), so keep the original lower bounds there. Skip rag/memory extras in CI on Python 3.14 because chromadb still uses pydantic v1 which is incompatible with 3.14.
1 parent ddc37f7 commit fd6eba9

2 files changed

Lines changed: 11 additions & 5 deletions

File tree

.github/workflows/pytest.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,17 @@ jobs:
2929
- name: Install uv
3030
uses: astral-sh/setup-uv@v7
3131
- name: Run pytest (macOS - all extras)
32-
if: matrix.os == 'macos-latest'
32+
if: matrix.os == 'macos-latest' && matrix.python-version != '3.14'
3333
run: uv run --all-extras pytest -vvv
34+
- name: Run pytest (macOS 3.14 - exclude rag/memory, chromadb uses pydantic v1)
35+
if: matrix.os == 'macos-latest' && matrix.python-version == '3.14'
36+
run: uv run --extra audio --extra llm --extra vad --extra faster-whisper --extra mlx-whisper --extra piper --extra kokoro --extra server --extra speed --extra test pytest -vvv --ignore=tests/rag --ignore=tests/memory
3437
- name: Run pytest (non-macOS - exclude mlx-whisper)
35-
if: matrix.os != 'macos-latest'
38+
if: matrix.os != 'macos-latest' && matrix.python-version != '3.14'
3639
run: uv run --extra audio --extra llm --extra rag --extra memory --extra vad --extra faster-whisper --extra piper --extra kokoro --extra server --extra speed --extra test pytest -vvv
40+
- name: Run pytest (non-macOS 3.14 - exclude mlx-whisper, rag/memory)
41+
if: matrix.os != 'macos-latest' && matrix.python-version == '3.14'
42+
run: uv run --extra audio --extra llm --extra vad --extra faster-whisper --extra piper --extra kokoro --extra server --extra speed --extra test pytest -vvv --ignore=tests/rag --ignore=tests/memory
3743
- name: Upload coverage reports to Codecov
3844
if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.14'
3945
uses: codecov/codecov-action@v5

pyproject.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ rag = [
4444
"chromadb>=0.4.22",
4545
"openai>=1.0.0", # Required by chromadb's OpenAIEmbeddingFunction
4646
"onnxruntime>=1.24.1; sys_platform != 'win32'",
47-
"onnxruntime>=1.17.0; sys_platform == 'win32'", # markitdown pins onnxruntime<=1.20.1 on Windows (microsoft/markitdown#1551)
47+
"onnxruntime>=1.17.0; sys_platform == 'win32'", # markitdown caps onnxruntime<=1.20.1 on Windows (microsoft/markitdown#1551)
4848
"huggingface-hub>=0.20.0",
4949
"transformers>=4.30.0",
5050
"watchfiles>=0.21.0",
@@ -57,7 +57,7 @@ memory = [
5757
"chromadb>=0.4.22",
5858
"openai>=1.0.0", # Required by chromadb's OpenAIEmbeddingFunction
5959
"onnxruntime>=1.24.1; sys_platform != 'win32'",
60-
"onnxruntime>=1.17.0; sys_platform == 'win32'", # markitdown pins onnxruntime<=1.20.1 on Windows (microsoft/markitdown#1551)
60+
"onnxruntime>=1.17.0; sys_platform == 'win32'", # markitdown caps onnxruntime<=1.20.1 on Windows (microsoft/markitdown#1551)
6161
"huggingface-hub>=0.20.0",
6262
"transformers>=4.30.0",
6363
"watchfiles>=0.21.0",
@@ -66,7 +66,7 @@ memory = [
6666
]
6767
vad = [
6868
"onnxruntime>=1.24.1; sys_platform != 'win32'",
69-
"onnxruntime>=1.16.0; sys_platform == 'win32'", # markitdown pins onnxruntime<=1.20.1 on Windows (microsoft/markitdown#1551)
69+
"onnxruntime>=1.16.0; sys_platform == 'win32'", # markitdown caps onnxruntime<=1.20.1 on Windows (microsoft/markitdown#1551)
7070
]
7171
faster-whisper = [
7272
"fastapi[standard]",

0 commit comments

Comments
 (0)