refactor: use DateTimeOffset for Unix timestamp calculations#1701
Open
unsafePtr wants to merge 1 commit into
Open
refactor: use DateTimeOffset for Unix timestamp calculations#1701unsafePtr wants to merge 1 commit into
unsafePtr wants to merge 1 commit into
Conversation
unsafePtr
force-pushed
the
refactor/datetime-unix-epoch
branch
from
60c2519 to
01a1eb9
Compare
Owner
|
Hi, did you test it on mono with raspberry or .net8 on docker / raspberry |
unsafePtr
force-pushed
the
refactor/datetime-unix-epoch
branch
from
01a1eb9 to
1f412ec
Compare
unsafePtr
force-pushed
the
refactor/datetime-unix-epoch
branch
from
1f412ec to
762da88
Compare
Author
|
@bassmaster187 , dropped polyfyll, it's not supproted in mono. Tested against mono docker instance |
unsafePtr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded
new DateTime(1970, 1, 1, ...)withDateTimeOffsetbuilt-in methods (ToUnixTimeSeconds,ToUnixTimeMilliseconds,FromUnixTimeMilliseconds). Works on Mono and all .NET targets without any polyfill.