Add a GitHub Action to replace TravisCI#94
Conversation
|
@leso-kn your review on this one, please. |
leso-kn
left a comment
leso-kn
left a comment
There was a problem hiding this comment.
Thanks for your submission! I wrote some comments :)
| - env: | ||
| PYTHON_LIBRT: "amd64" # "x64" | ||
| run: pip install --editable . || true # TODO: Always fails even with $PYTHON_LIBRT defined! | ||
| - run: pip install lunatic-python-universal # Workaround: Install from PyPI |
There was a problem hiding this comment.
Thank you for your contribution :) It looks like this line will overwrite the local library version with the one published on PyPI or am I interpreting something wrong?
There was a problem hiding this comment.
The local one does NOT install. If we can get it to install, then we can remove the PyPI install.
I will do more once we get pip install --editable . to pass. Help please.
| runs-on: ubuntu-26.04 | ||
| steps: | ||
| - run: sudo apt-get update | ||
| - run: sudo apt-get install -y lua5.1 liblua5.1-0-dev |
There was a problem hiding this comment.
As a side-note: Ideally we should test multiple lua versions using a matrix job. But we can split that off into a separate PR, so no pressure!
There was a problem hiding this comment.
Happy to, but let's get the local install to work first.
| run: pip install --editable . || true # TODO: Always fails even with $PYTHON_LIBRT defined! | ||
| - run: pip install lunatic-python-universal # Workaround: Install from PyPI | ||
| - shell: python # Sanity check | ||
| run: | |
There was a problem hiding this comment.
Ideally this should just run tests/test_lua.py and tests/test_py.lua.
Did you try to use them, are they broken?
Do feel free to use the legacy .travis.yml file as a reference :)
There was a problem hiding this comment.
python tests/test_lua.py generates a SegFault. See:
tests/test_py.lua fails also in #93.
I will do more once we get pip install --editable . to pass.
2 participants
Test results: https://github.com/cclauss/lunatic-python/actions
Why does this line fail?!?
%
pip install --editable .