batocera-systems: align ColecoVision BIOS path with actual emulator location#15756
Open
WizzardSK wants to merge 1 commit into
Open
batocera-systems: align ColecoVision BIOS path with actual emulator location#15756WizzardSK wants to merge 1 commit into
WizzardSK wants to merge 1 commit into
Conversation
…ocation The Missing-BIOS check listed 'bios/colecovision.rom', but no emulator packaged in Batocera reads from that path. Users who set up the BIOS correctly per the wiki (where BlueMSX, the default core, expects 'bios/Machines/COL - ColecoVision/coleco.rom') were still being told the BIOS is missing. Point the check at the BlueMSX path, since BlueMSX is the default core for ColecoVision. Same MD5, same 8 KB boot ROM; just at the path that actually corresponds to a working setup. Other emulators continue to read from their own paths (CLK: bios/ColecoVision/coleco.rom, OpenMSX: system/configs/openmsx/share/systemroms/coleco.rom) and are independent of this check.
Contributor
|
the right path for openmsx is /userdata/bios/openmsx/coleco.rom |
Contributor
Author
|
Thanks @zognic — you're right, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Missing-BIOS check (Main Menu → System Settings → Missing BIOS) reports the ColecoVision BIOS as missing even when the user has set it up correctly per the wiki.
Root cause
batocera-systemslists the required file asbios/colecovision.rom, but no emulator packaged in Batocera reads from that path:bios/Machines/COL - ColecoVision/coleco.rombios/openmsx/coleco.rom(filepool registered byopenmsxGenerator.py;bios/Machinesalso works)bios/ColecoVision/coleco.rom(per CLK's own ROMCatalogue)The "canonical" path
bios/colecovision.romis only referenced inbatocera-systems; nothing else in the repo reads from it. Users who place the file at the BlueMSX path the wiki documents have a working setup but the check still complains.Change
Point the check at the BlueMSX path, since BlueMSX is the default core for ColecoVision. Same MD5 (
2c66f5911e5b42b8ebe113403548eee7), same 8 KB boot ROM — just at the path that actually corresponds to a working setup.Other emulators continue to read from their own paths and are independent of this check.