fix: Non-breaking bug fixes, code quality improvements, and dead dependency removal (#41)

* fix: Non-breaking bug fixes, code quality improvements, and dead dependency removal

Bug fixes:
- Fix path manipulation bug in FileManagementUtilities using String.Replace
  (fragile when sourceDirectory appears as substring in nested paths)
- Fix thread-safety in ConcurrentPersistentDictionary: all CRUD operations
  now use proper locking to match the class name's contract
- Fix resource leak in StreamUtils.CopyRessourceToFile (FileStream not
  disposed on exception)
- Fix bare catch blocks in OdbcConnectionManager (catch ArgumentException
  instead of all exceptions) and BGErrorTracking (catch Exception)
- Add missing GC.SuppressFinalize to IDisposable implementations across
  8 classes (FixerIOClient, GenericAPIClient, CSVFileReader, CSVFileWriter,
  ZIPFileUtils, CloudinaryImageManager, ApplicationController,
  ConcurrentPersistentDictionary)

Code quality:
- Fix spelling: 'Initalize' → 'Initialize' in 6 files (all private methods)
- Make Scheduler.ShutdownTimeout configurable (was hardcoded 30s)
- Make CloudinaryImageManager.MaxListResults configurable (was hardcoded 500)
- Make ApplicationController.Dispose virtual for subclass overrides

Dependency cleanup:
- Remove unused System.Data.SqlClient package (deprecated, has known CVEs,
  not referenced in any source file)

* fix: Address remaining consistency issues from code review

- Add GC.SuppressFinalize to 4 missed IDisposable classes:
  BGLoggerNetworkListener, LockingList, FileChangesMonitor,
  ChromeWebbrowserControl
- Fix bare catch block in BGErrorTrackingConfiguration (catch Exception)
- Harden FileManagementUtilities path normalization with Path.GetFullPath
  to prevent issues with mixed separators on netstandard2.0

Author: karlspace

Directory.Packages.props

@@ -43,7 +43,7 @@
     <PackageVersion Include="Microsoft.Win32.SystemEvents" Version="10.0.2" />
     <PackageVersion Include="System.Configuration.ConfigurationManager" Version="10.0.2" />
     <PackageVersion Include="System.Data.Odbc" Version="10.0.2" />
-    <PackageVersion Include="System.Data.SqlClient" Version="4.9.0" />
+
     <PackageVersion Include="System.ServiceProcess.ServiceController" Version="10.0.2" />
     <PackageVersion Include="System.Text.Encoding.CodePages" Version="10.0.2" />
     <PackageVersion Include="System.Collections.Immutable" Version="10.0.2" />

src/BAUERGROUP.Shared.API/API/GenericAPIClient.cs

@@ -61,11 +61,11 @@ public GenericAPIClient(String url, Int32 timeout = 10 * 1000, IWebProxy? proxy
                 })
             );
 
-            Initalize();
+            Initialize();
             Authenticate();
         }
 
-        private void Initalize()
+        private void Initialize()
         {
             Client.AddDefaultHeader(KnownHeaders.Accept, "application/json");
         }
@@ -102,6 +102,7 @@ private void Validate(RestClientOptions clientOptions)
         public void Dispose()
         {
             Client?.Dispose();
+            GC.SuppressFinalize(this);
         }
 
         protected async Task<T> ExceptionHandlerAsync<T>(Func<Task<T>> action)

src/BAUERGROUP.Shared.Cloud/CloudinaryClient/CloudinaryImageManager.cs

@@ -24,6 +24,11 @@ public class CloudinaryImageManager : IDisposable
         /// </summary>
         protected Cloudinary Client { get; private set; } = null!;
 
+        /// <summary>
+        /// Gets or sets the maximum number of results returned by list operations. Default is 500.
+        /// </summary>
+        public int MaxListResults { get; set; } = 500;
+
         /// <summary>
         /// Initializes a new instance of the <see cref="CloudinaryImageManager"/> class.
         /// </summary>
@@ -32,10 +37,10 @@ public CloudinaryImageManager(CloudinaryImageManagerConfiguration configuration)
         {
             Configuration = configuration;
 
-            Initalize();
+            Initialize();
         }
 
-        private void Initalize()
+        private void Initialize()
         {
             var account = new Account(Configuration.Name, Configuration.APIKey, Configuration.APISecret);
             Client = new Cloudinary(account);
@@ -46,7 +51,7 @@ private void Initalize()
         /// </summary>
         public void Dispose()
         {
-
+            GC.SuppressFinalize(this);
         }
 
         /// <summary>
@@ -183,7 +188,7 @@ public Resource[] List(String? uniqueIdentifier = null, CloudinaryContentType co
         {
             var listParameters = new ListResourcesParams()
             {
-                MaxResults = 500,
+                MaxResults = MaxListResults,
                 ResourceType = contentType == CloudinaryContentType.Image ? ResourceType.Image : ResourceType.Video
             };
 

src/BAUERGROUP.Shared.Cloud/FixerIO/FixerIOClient.cs

@@ -69,7 +69,7 @@ public FixerIOClient(FixerIOConfiguration configuration)
                 })
             );
 
-            Initalize();
+            Initialize();
         }
 
         private void Validate()
@@ -78,7 +78,7 @@ private void Validate()
                 throw new FixerIOClientException($"Invalid API URL '{Configuration.URL}'.", new ArgumentException("Invalid URL"));
         }
 
-        private void Initalize()
+        private void Initialize()
         {
             Client.AddDefaultHeader(KnownHeaders.Accept, "application/json");
         }
@@ -97,6 +97,7 @@ private static string GetUserAgent()
         public void Dispose()
         {
             Client.Dispose();
+            GC.SuppressFinalize(this);
         }
 
         protected async Task<T> ExceptionHandlerAsync<T>(Func<Task<T>> action)

src/BAUERGROUP.Shared.Core/Application/ApplicationController.cs

@@ -9,22 +9,22 @@ namespace BAUERGROUP.Shared.Core.Application
     /// <summary>
     /// Base class for application lifecycle management.
     /// </summary>
-    public class ApplicationController: IDisposable
+    public class ApplicationController : IDisposable
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="ApplicationController"/> class.
         /// </summary>
         public ApplicationController()
         {
-
         }
 
         /// <summary>
         /// Releases all resources used by the <see cref="ApplicationController"/>.
+        /// Subclasses should override this method to release managed resources.
         /// </summary>
-        public void Dispose()
+        public virtual void Dispose()
         {
-
+            GC.SuppressFinalize(this);
         }
     }
 }

src/BAUERGROUP.Shared.Core/ErrorTracking/BGErrorTracking.cs

@@ -101,7 +101,7 @@ private static string GetDefaultRelease()
                 var version = assembly.GetName().Version;
                 return $"{name}@{version}";
             }
-            catch
+            catch (Exception)
             {
                 return "unknown";
             }

src/BAUERGROUP.Shared.Core/ErrorTracking/BGErrorTrackingConfiguration.cs

@@ -17,7 +17,7 @@ public BGErrorTrackingConfiguration()
                 var assembly = Assembly.GetEntryAssembly() ?? Assembly.GetExecutingAssembly();
                 ApplicationName = Path.GetFileNameWithoutExtension(assembly.Location);
             }
-            catch
+            catch (Exception)
             {
                 ApplicationName = "Unknown";
             }

src/BAUERGROUP.Shared.Core/Files/CSVFileReader.cs

@@ -44,6 +44,8 @@ public void Dispose()
 
             _cr = null;
             _sr = null;
+
+            GC.SuppressFinalize(this);
         }
 
         public void Close()

src/BAUERGROUP.Shared.Core/Files/CSVFileWriter.cs

@@ -45,6 +45,8 @@ public void Dispose()
 
             _cw = null;
             _sw = null;
+
+            GC.SuppressFinalize(this);
         }
 
         public void Close()

src/BAUERGROUP.Shared.Core/Files/FileChangesMonitor.cs

@@ -36,6 +36,7 @@ private void OnFileChanged(Object sender, FileSystemEventArgs e)
         public void Dispose()
         {
             _fsw.Dispose();
+            GC.SuppressFinalize(this);
         }
     }
 }