Skip to content

Commit f8a1141

Browse files
authored
fix: allow override opt dbg and fastbuild flags (#363)
The order was correct in the clang toolchain config. Setting this order allow user compile flags like copts attribute to come after the copts from the ones expanded by the opt, dbg and fastbuild features.
1 parent 28177e2 commit f8a1141

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

cuda/private/toolchain_configs/nvcc.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -531,13 +531,13 @@ def _impl(ctx):
531531
host_compiler_feature,
532532
supports_compiler_device_link_feature,
533533
include_paths_feature,
534+
dbg_feature,
535+
opt_feature,
536+
fastbuild_feature,
534537
defines_feature,
535538
host_defines_feature,
536539
compile_flags_feature,
537540
host_compile_flags_feature,
538-
dbg_feature,
539-
opt_feature,
540-
fastbuild_feature,
541541
sysroot_feature,
542542
ptxas_flags_feature,
543543
compiler_input_flags_feature,

cuda/private/toolchain_configs/nvcc_msvc.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -571,13 +571,13 @@ def _impl(ctx):
571571
arch_all_major_feature,
572572
default_compile_flags_feature,
573573
include_paths_feature,
574+
dbg_feature,
575+
opt_feature,
576+
fastbuild_feature,
574577
defines_feature,
575578
host_defines_feature,
576579
compile_flags_feature,
577580
host_compile_flags_feature,
578-
dbg_feature,
579-
opt_feature,
580-
fastbuild_feature,
581581
generate_pdb_file_feature,
582582
frame_pointer_feature,
583583
static_link_msvcrt_debug_feature,

0 commit comments

Comments
 (0)