Skip to content

Commit b8d437c

Browse files
authored
examples: enable pcre on windows (#1524)
With the longpath fix (and fixing the name of the lib) pcre should work now!
1 parent f0385a0 commit b8d437c

1 file changed

Lines changed: 2 additions & 10 deletions

File tree

examples/third_party/pcre/BUILD.pcre.bazel

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,24 +18,16 @@ cmake(
1818
"CMAKE_DISABLE_FIND_PACKAGE_BZip2": "TRUE",
1919
"PCRE2_SUPPORT_LIBZ": "ON",
2020
} | select({
21-
"@platforms//os:windows": {
22-
# PCRE2 adds a "d" postfix for MSVC debug builds by default; keep the
23-
# archive name stable so Bazel can locate the declared output.
24-
"CMAKE_DEBUG_POSTFIX": "",
25-
},
21+
"@platforms//os:windows": {},
2622
"//conditions:default": {
2723
"CMAKE_C_FLAGS": "$${CMAKE_C_FLAGS:-} -fPIC",
2824
},
2925
}),
3026
lib_source = ":all_srcs",
3127
out_static_libs = select({
32-
"@platforms//os:windows": ["pcre2-8.lib"],
28+
"@platforms//os:windows": ["pcre2-8d.lib"],
3329
"//conditions:default": ["libpcre2-8.a"],
3430
}),
35-
target_compatible_with = select({
36-
"@platforms//os:windows": ["@rules_foreign_cc_examples_third_party//:broken"],
37-
"//conditions:default": [],
38-
}),
3931
deps = ["@examples_zlib//:zlib"],
4032
)
4133

0 commit comments

Comments
 (0)