Skip to content

Commit b485f14

Browse files
authored
Fix and test Bazel 9 support (#282)
1 parent c541437 commit b485f14

7 files changed

Lines changed: 25 additions & 13 deletions

File tree

.bazelversion

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8.2.1
1+
8.4.2

.bcr/presubmit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ bcr_test_module:
33
matrix:
44
# java_fuzz_test fails on macos_arm64 due to code signing violation
55
platform: ["ubuntu2204", "macos"]
6-
bazel: ["7.*", "8.*"]
6+
bazel: ["7.*", "8.*", "9.*"]
77
tasks:
88
run_tests:
99
name: "Run test module"

.github/workflows/bazel_test.yml

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -174,20 +174,24 @@ jobs:
174174
bzlmod_examples_libfuzzer:
175175
name: Bzlmod examples (libFuzzer)
176176
runs-on: ubuntu-latest
177+
strategy:
178+
matrix:
179+
bazel: ["7.*", "8.*", "9.*"]
177180
steps:
178181
- name: Checkout repository
179182
uses: actions/checkout@v2
180-
- name: Run regression tests on macOS
181-
run: |
182-
cd examples/bzlmod
183-
bazel test --verbose_failures --test_output=all --@my_rules_fuzzing//fuzzing:cc_engine=@my_rules_fuzzing//fuzzing/engines:libfuzzer //...
183+
- name: Run Bzlmod tests with libFuzzer
184+
working-directory: examples/bzlmod
185+
run: USE_BAZEL_VERSION=${{ matrix.bazel }} bazel test --verbose_failures --test_output=all --@my_rules_fuzzing//fuzzing:cc_engine=@my_rules_fuzzing//fuzzing/engines:libfuzzer //...
184186
bzlmod_examples_replay:
185187
name: Bzlmod examples (replay)
186188
runs-on: ubuntu-latest
189+
strategy:
190+
matrix:
191+
bazel: ["7.*", "8.*", "9.*"]
187192
steps:
188193
- name: Checkout repository
189194
uses: actions/checkout@v2
190-
- name: Run regression tests on macOS
191-
run: |
192-
cd examples/bzlmod
193-
bazel test --verbose_failures --test_output=all --@my_rules_fuzzing//fuzzing:cc_engine=@my_rules_fuzzing//fuzzing/engines:replay //...
195+
- name: Run Bzlmod tests with replay
196+
working-directory: examples/bzlmod
197+
run: USE_BAZEL_VERSION=${{ matrix.bazel }} bazel test --verbose_failures --test_output=all --@my_rules_fuzzing//fuzzing:cc_engine=@my_rules_fuzzing//fuzzing/engines:replay //...

MODULE.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ bazel_dep(name = "abseil-cpp", version = "20240116.1", repo_name = "com_google_a
2323
bazel_dep(name = "bazel_skylib", version = "1.5.0")
2424
bazel_dep(name = "platforms", version = "0.0.8")
2525
bazel_dep(name = "rules_python", version = "0.28.0")
26-
bazel_dep(name = "rules_cc", version = "0.0.17")
26+
bazel_dep(name = "rules_cc", version = "0.2.1")
2727
bazel_dep(name = "rules_java", version = "6.5.2")
2828
bazel_dep(name = "rules_shell", version = "0.3.0")
2929

3030
bazel_dep(name = "stardoc", version = "0.6.2", dev_dependency = True, repo_name = "io_bazel_stardoc")
31-
bazel_dep(name = "googletest", version = "1.14.0.bcr.1", dev_dependency = True, repo_name = "com_google_googletest")
31+
bazel_dep(name = "googletest", version = "1.17.0.bcr.2", dev_dependency = True, repo_name = "com_google_googletest")
3232
bazel_dep(name = "re2", version = "2023-11-01", dev_dependency = True)
3333

3434
non_module_dependencies = use_extension("//fuzzing/private:extensions.bzl", "non_module_dependencies")

docs/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ bzl_library(
4545
"//fuzzing/private:regression.bzl",
4646
"//fuzzing/private:util.bzl",
4747
"//fuzzing/private/oss_fuzz:package.bzl",
48-
"@rules_cc//cc:bzl_srcs",
48+
"@rules_cc//cc:core_rules",
4949
"@rules_fuzzing_oss_fuzz//:instrum.bzl",
5050
"@rules_java//java:rules",
5151
],

fuzzing/private/oss_fuzz/BUILD.tpl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15+
load("@rules_cc//cc:cc_library.bzl", "cc_library")
16+
load("@rules_java//java:java_library.bzl", "java_library")
17+
load("@rules_java//java:java_import.bzl", "java_import")
1518
load("@rules_fuzzing//fuzzing:cc_defs.bzl", "cc_fuzzing_engine")
1619
load("@rules_fuzzing//fuzzing:java_defs.bzl", "java_fuzzing_engine")
1720

@@ -40,6 +43,8 @@ java_fuzzing_engine(
4043
java_import(
4144
name = "oss_fuzz_java_stub",
4245
jars = [%{jazzer_jars}],
46+
) if [%{jazzer_jars}] else java_library(
47+
name = "oss_fuzz_java_stub",
4348
)
4449

4550

honggfuzz.BUILD

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919
# * libunwind-dev
2020
# * libblocksruntime-dev
2121

22+
load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
23+
load("@rules_cc//cc:cc_library.bzl", "cc_library")
24+
2225
# Disable the layering check for including the external headers.
2326
package(features = ["-layering_check"])
2427

0 commit comments

Comments
 (0)