Fix path flattening collisions and make runfiles resolution deterministic in make_corpus_dir#290
Open
jmestwa-coder wants to merge 1 commit into
Open
Conversation
…stic in make_corpus_dir
e2e4d68 to
c328a1a
Compare
Author
|
Hi @fmeum, @simonresch Can you kindly review this PR. Thank you! |
Collaborator
|
The only caller of Could you make sure the added test passes? You can run it with the command |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes path flattening collisions and makes runfiles resolution deterministic in
make_corpus_dir.Problem
dir/../a.txtvsa.txt,./a.txtvsdot-a.txt)Solution
_mainonly as fallbackResult
Tests
TEST_SRCDIRRUNFILES_DIRRUNFILES_MANIFEST_FILE