Commit 888d216
committed
Revert host-sensitive Bazel 8 platform swaps
Partially revert the recent replacement of
@bazel_tools//src/conditions:host_windows with
@platforms//os:windows.
The direct replacement is correct for js_library, which was the main
source of the Bazel 8 deprecation warning flood from generated npm
targets.
However, it changes semantics in host-sensitive helpers such as
copy_to_bin, params_file, npm_link, pkg_npm, and the vendored skylib
copy_file rule. In those places, the old condition described the
host/execution machine, while @platforms//os:windows selects on the
target platform instead. Bazel's platform/config_setting docs make that
distinction explicit. This caused regressions in packaging/publishing
flows.
Keep the js_library migration for warning reduction, and restore the
old behavior in the host-sensitive rules until they can be migrated with
a proper host-aware replacement.
Fixes regression in npm packaging/publishing after a66fc4f1 parent a66fc4f commit 888d216
5 files changed
Lines changed: 6 additions & 6 deletions
File tree
- internal
- common
- linker
- pkg_npm
- third_party/github.com/bazelbuild/bazel-skylib/rules/private
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
| 61 | + | |
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
128 | | - | |
| 128 | + | |
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
154 | | - | |
| 154 | + | |
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
376 | 376 | | |
377 | 377 | | |
378 | 378 | | |
379 | | - | |
| 379 | + | |
380 | 380 | | |
381 | 381 | | |
382 | 382 | | |
383 | 383 | | |
384 | 384 | | |
385 | 385 | | |
386 | 386 | | |
387 | | - | |
| 387 | + | |
388 | 388 | | |
389 | 389 | | |
390 | 390 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
206 | | - | |
| 206 | + | |
207 | 207 | | |
208 | 208 | | |
209 | 209 | | |
| |||
0 commit comments