Skip to content

Commit 03ec84f

Browse files
committed
cleanup
1 parent 70ccdc8 commit 03ec84f

2 files changed

Lines changed: 5 additions & 14 deletions

File tree

.bazelci/presubmit.yml

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -227,20 +227,18 @@ tasks:
227227
# for now until we can look into it.
228228
build_targets:
229229
- "--"
230-
##- "..."
231-
### As a regression test for #225, check that wheel targets still build when
232-
### their package path is qualified with the repo name.
233-
##- "@rules_python//examples/wheel/..."
234-
- "//tests/py_zipapp:system_python_zipapp_test"
230+
- "..."
231+
# As a regression test for #225, check that wheel targets still build when
232+
# their package path is qualified with the repo name.
233+
- "@rules_python//examples/wheel/..."
235234
build_flags:
236235
- "--noenable_bzlmod"
237236
- "--enable_workspace"
238237
- "--keep_going"
239238
- "--build_tag_filters=-integration-test"
240239
test_targets:
241240
- "--"
242-
##- "..."
243-
- "//tests/py_zipapp:system_python_zipapp_test"
241+
- "..."
244242
test_flags:
245243
- "--noenable_bzlmod"
246244
- "--enable_workspace"
@@ -258,14 +256,8 @@ tasks:
258256
<<: *reusable_config
259257
name: "Default: Windows"
260258
platform: windows
261-
build_targets:
262-
- "--"
263-
- "//tests/py_zipapp:system_python_zipapp_test"
264259
test_flags:
265260
- "--test_tag_filters=-integration-test,-fix-windows"
266-
test_targets:
267-
- "--"
268-
- "//tests/py_zipapp:system_python_zipapp_test"
269261
rbe_min:
270262
<<: *minimum_supported_version
271263
<<: *reusable_config

python/private/zipapp/zip_main_template.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,6 @@ def main():
275275
if not os.path.lexists(python_program):
276276
# The venv bin/python3 interpreter should always be under runfiles, but
277277
# double check. We don't want to accidentally create symlinks elsewhere
278-
# or unlink outside our tree.
279278
if not python_program.startswith(module_space):
280279
raise AssertionError(
281280
"Program's venv binary not under runfiles: {python_program}"

0 commit comments

Comments
 (0)