chore: make pipstar non-switchable

At the same time cleanup pystar env var docs.

Author: aignas

docs/environment-variables.md

@@ -52,32 +52,6 @@ When `1`, `rules_python` will warn users about deprecated functionality that wil
 be removed in a subsequent major `rules_python` version. Defaults to `0` if unset.
 :::
 
-::::{envvar} RULES_PYTHON_ENABLE_PYSTAR
-
-When `1`, the `rules_python` Starlark implementation of the core rules is used
-instead of the Bazel-builtin rules. Note that this requires Bazel 7+. Defaults
-to `1`.
-
-:::{versionadded} 0.26.0
-Defaults to `0` if unspecified.
-:::
-:::{versionchanged} 0.40.0
-The default became `1` if unspecified
-:::
-::::
-
-::::{envvar} RULES_PYTHON_ENABLE_PIPSTAR
-
-When `1`, the `rules_python` Starlark implementation of the PyPI/pip integration is used
-instead of the legacy Python scripts.
-
-:::{versionadded} 1.5.0
-:::
-:::{versionchanged} 1.7.0
-Flipped to be enabled by default.
-:::
-::::
-
 ::::{envvar} RULES_PYTHON_EXTRACT_ROOT
 
 Directory to use as the root for creating files necessary for bootstrapping so

docs/readthedocs_build.sh

@@ -12,10 +12,7 @@ done < <(env -0)
 # In order to get the build number, we extract it from the host name
 extra_env+=("--@sphinxdocs//sphinxdocs:extra_env=HOSTNAME=$HOSTNAME")
 
-export RULES_PYTHON_ENABLE_PIPSTAR=1
-
 set -x
-export RULES_PYTHON_ENABLE_PIPSTAR=1
 bazel run \
   --config=rtd \
   "--@sphinxdocs//sphinxdocs:extra_defines=version=$READTHEDOCS_VERSION" \

python/private/internal_config_repo.bzl

@@ -21,8 +21,6 @@ settings for rules to later use.
 load("//python/private:text_util.bzl", "render")
 load(":repo_utils.bzl", "repo_utils")
 
-_ENABLE_PIPSTAR_ENVVAR_NAME = "RULES_PYTHON_ENABLE_PIPSTAR"
-_ENABLE_PIPSTAR_DEFAULT = "1"
 _ENABLE_DEPRECATION_WARNINGS_ENVVAR_NAME = "RULES_PYTHON_DEPRECATION_WARNINGS"
 _ENABLE_DEPRECATION_WARNINGS_DEFAULT = "0"
 
@@ -31,7 +29,6 @@ config = struct(
   build_python_zip_default = {build_python_zip_default},
   supports_whl_extraction = {supports_whl_extraction},
   enable_pystar = True,
-  enable_pipstar = {enable_pipstar},
   enable_deprecation_warnings = {enable_deprecation_warnings},
   bazel_8_or_later = {bazel_8_or_later},
   bazel_9_or_later = {bazel_9_or_later},
@@ -104,7 +101,6 @@ def _internal_config_repo_impl(rctx):
 
     rctx.file("rules_python_config.bzl", _CONFIG_TEMPLATE.format(
         build_python_zip_default = repo_utils.get_platforms_os_name(rctx) == "windows",
-        enable_pipstar = _bool_from_environ(rctx, _ENABLE_PIPSTAR_ENVVAR_NAME, _ENABLE_PIPSTAR_DEFAULT),
         enable_deprecation_warnings = _bool_from_environ(rctx, _ENABLE_DEPRECATION_WARNINGS_ENVVAR_NAME, _ENABLE_DEPRECATION_WARNINGS_DEFAULT),
         builtin_py_info_symbol = builtin_py_info_symbol,
         builtin_py_runtime_info_symbol = builtin_py_runtime_info_symbol,
@@ -139,7 +135,7 @@ def _internal_config_repo_impl(rctx):
 internal_config_repo = repository_rule(
     implementation = _internal_config_repo_impl,
     configure = True,
-    environ = [_ENABLE_PIPSTAR_ENVVAR_NAME],
+    environ = [],
     attrs = {
         "transition_setting_generators": attr.string_list_dict(),
         "transition_settings": attr.string_list(),

python/private/pypi/extension.bzl

@@ -447,10 +447,6 @@ Supported keys:
 * `platform_system`, defaults to a value inferred from the {attr}`os_name`.
 * `platform_version`, defaults to `0`.
 * `sys_platform`, defaults to a value inferred from the {attr}`os_name`.
-
-::::{note}
-This is only used if the {envvar}`RULES_PYTHON_ENABLE_PIPSTAR` is enabled.
-::::
 """,
     ),
     "index_url": attr.string(

python/private/pypi/whl_library.bzl

@@ -344,9 +344,7 @@ def _whl_library_impl(rctx):
             # build deps from PyPI (e.g. `flit_core`) if they are missing.
             extra_pip_args.extend(["--find-links", "."])
 
-    # also enable pipstar for any whls that are downloaded without `pip`
-    enable_pipstar = (rp_config.enable_pipstar or whl_path) and rctx.attr.config_load
-    enable_pipstar_extract = enable_pipstar and rp_config.bazel_8_or_later
+    enable_pipstar_extract = rp_config.bazel_8_or_later
 
     # When pipstar is enabled, Python isn't used, so there's no need
     # to setup env vars to run Python, unless we need to build an sdist
@@ -428,65 +426,34 @@ def _whl_library_impl(rctx):
             logger = logger,
         )
 
-    # NOTE @aignas 2025-09-28: if someone has an old vendored file that does not have the
-    # dep_template set or the packages is not set either, we should still not break, best to
-    # disable pipstar for that particular case.
-    #
-    # Remove non-pipstar and config_load check when we release rules_python 2.
-    if enable_pipstar:
-        install_dir_path = whl_path.dirname.get_child("site-packages")
-        metadata = whl_metadata(
-            install_dir = install_dir_path,
-            read_fn = rctx.read,
-            logger = logger,
-        )
-        namespace_package_files = pypi_repo_utils.find_namespace_package_files(rctx, install_dir_path)
-
-        build_file_contents = generate_whl_library_build_bazel(
-            name = whl_path.basename,
-            sdist_filename = sdist_filename,
-            dep_template = rctx.attr.dep_template or "@{}{{name}}//:{{target}}".format(
-                rctx.attr.repo_prefix,
-            ),
-            config_load = rctx.attr.config_load,
-            metadata_name = metadata.name,
-            metadata_version = metadata.version,
-            requires_dist = metadata.requires_dist,
-            # TODO @aignas 2025-05-17: maybe have a build flag for this instead
-            enable_implicit_namespace_pkgs = rctx.attr.enable_implicit_namespace_pkgs,
-            # TODO @aignas 2025-04-14: load through the hub:
-            annotation = None if not rctx.attr.annotation else struct(**json.decode(rctx.read(rctx.attr.annotation))),
-            data_exclude = rctx.attr.pip_data_exclude,
-            group_deps = rctx.attr.group_deps,
-            group_name = rctx.attr.group_name,
-            namespace_package_files = namespace_package_files,
-            extras = requirement(rctx.attr.requirement).extras,
-        )
-    else:
-        metadata = json.decode(rctx.read("metadata.json"))
-        rctx.delete("metadata.json")
-
-        namespace_package_files = pypi_repo_utils.find_namespace_package_files(rctx, rctx.path("site-packages"))
-
-        build_file_contents = generate_whl_library_build_bazel(
-            name = whl_path.basename,
-            sdist_filename = sdist_filename,
-            dep_template = rctx.attr.dep_template or "@{}{{name}}//:{{target}}".format(rctx.attr.repo_prefix),
-            # TODO @aignas 2025-05-17: maybe have a build flag for this instead
-            enable_implicit_namespace_pkgs = rctx.attr.enable_implicit_namespace_pkgs,
-            # TODO @aignas 2025-04-14: load through the hub:
-            dependencies = metadata["deps"],
-            dependencies_by_platform = metadata["deps_by_platform"],
-            annotation = None if not rctx.attr.annotation else struct(**json.decode(rctx.read(rctx.attr.annotation))),
-            data_exclude = rctx.attr.pip_data_exclude,
-            group_deps = rctx.attr.group_deps,
-            group_name = rctx.attr.group_name,
-            tags = [
-                "pypi_name={}".format(metadata["name"]),
-                "pypi_version={}".format(metadata["version"]),
-            ],
-            namespace_package_files = namespace_package_files,
-        )
+    install_dir_path = whl_path.dirname.get_child("site-packages")
+    metadata = whl_metadata(
+        install_dir = install_dir_path,
+        read_fn = rctx.read,
+        logger = logger,
+    )
+    namespace_package_files = pypi_repo_utils.find_namespace_package_files(rctx, install_dir_path)
+
+    build_file_contents = generate_whl_library_build_bazel(
+        name = whl_path.basename,
+        sdist_filename = sdist_filename,
+        dep_template = rctx.attr.dep_template or "@{}{{name}}//:{{target}}".format(
+            rctx.attr.repo_prefix,
+        ),
+        config_load = rctx.attr.config_load,
+        metadata_name = metadata.name,
+        metadata_version = metadata.version,
+        requires_dist = metadata.requires_dist,
+        # TODO @aignas 2025-05-17: maybe have a build flag for this instead
+        enable_implicit_namespace_pkgs = rctx.attr.enable_implicit_namespace_pkgs,
+        # TODO @aignas 2025-04-14: load through the hub:
+        annotation = None if not rctx.attr.annotation else struct(**json.decode(rctx.read(rctx.attr.annotation))),
+        data_exclude = rctx.attr.pip_data_exclude,
+        group_deps = rctx.attr.group_deps,
+        group_name = rctx.attr.group_name,
+        namespace_package_files = namespace_package_files,
+        extras = requirement(rctx.attr.requirement).extras,
+    )
 
     # Delete these in case the wheel had them. They generally don't cause
     # a problem, but let's avoid the chance of that happening.
@@ -509,7 +476,7 @@ def _whl_library_impl(rctx):
 
     rctx.file("BUILD.bazel", build_file_contents)
 
-    if enable_pipstar and enable_pipstar_extract:
+    if enable_pipstar_extract:
         if hasattr(rctx, "repo_metadata"):
             return rctx.repo_metadata(reproducible = True)