Skip to content

Commit 1169efd

Browse files
authored
chore: remove py_proto_library from bzlmod example (#3508)
With the py_proto_library rules removed from rules_python, rules_python is no longer the appropriate place to have examples for using the py_proto_library rules. Having such example also causes some maintenance burden, as apparently it incurs a nodejs dependency, which fails under newer bazel versions. Fixes #3362
1 parent 53cdb39 commit 1169efd

File tree

14 files changed

+0
-177
lines changed

14 files changed

+0
-177
lines changed

examples/bzlmod/.bazelignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
other_module
2-
py_proto_library/foo_external
32
vendor

examples/bzlmod/MODULE.bazel

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ local_path_override(
1212
path = "../..",
1313
)
1414

15-
# (py_proto_library specific) Add the protobuf library for well-known types (e.g. `Any`, `Timestamp`, etc)
16-
bazel_dep(name = "protobuf", version = "27.0", repo_name = "com_google_protobuf")
17-
1815
# Only needed to make rules_python's CI happy. rules_java 8.3.0+ is needed so
1916
# that --java_runtime_version=remotejdk_11 works with Bazel 8.
2017
bazel_dep(name = "rules_java", version = "8.16.1")
@@ -291,11 +288,5 @@ local_path_override(
291288
path = "other_module",
292289
)
293290

294-
bazel_dep(name = "foo_external", version = "")
295-
local_path_override(
296-
module_name = "foo_external",
297-
path = "py_proto_library/foo_external",
298-
)
299-
300291
# example test dependencies
301292
bazel_dep(name = "rules_shell", version = "0.3.0", dev_dependency = True)

examples/bzlmod/py_proto_library/BUILD.bazel

Lines changed: 0 additions & 35 deletions
This file was deleted.

examples/bzlmod/py_proto_library/example.com/another_proto/BUILD.bazel

Lines changed: 0 additions & 16 deletions
This file was deleted.

examples/bzlmod/py_proto_library/example.com/another_proto/message.proto

Lines changed: 0 additions & 10 deletions
This file was deleted.

examples/bzlmod/py_proto_library/example.com/proto/BUILD.bazel

Lines changed: 0 additions & 17 deletions
This file was deleted.

examples/bzlmod/py_proto_library/example.com/proto/pricetag.proto

Lines changed: 0 additions & 11 deletions
This file was deleted.

examples/bzlmod/py_proto_library/foo_external/BUILD.bazel

Lines changed: 0 additions & 22 deletions
This file was deleted.

examples/bzlmod/py_proto_library/foo_external/MODULE.bazel

Lines changed: 0 additions & 7 deletions
This file was deleted.

examples/bzlmod/py_proto_library/foo_external/WORKSPACE

Whitespace-only changes.

0 commit comments

Comments
 (0)