Skip to content

Commit 25895ab

Browse files
committed
add the correct flags
1 parent e630cb8 commit 25895ab

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

tests/base_rules/py_executable_base_tests.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ def _test_basic_windows(name, config):
4949
# platforms.
5050
# Pass value to both native and starlark versions of the flag until
5151
# the native one is removed.
52+
"//command_line_option:build_python_zip": "true",
5253
labels.BUILD_PYTHON_ZIP: True,
5354
"//command_line_option:cpu": "windows_x86_64",
5455
"//command_line_option:crosstool_top": CROSSTOOL_TOP,

tests/config_settings/transition/multi_version_tests.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ def _setup_py_binary_windows(name, *, impl, build_python_zip):
9292
target = name + "_subject",
9393
impl = impl,
9494
config_settings = {
95-
"//command_line_option:build_python_zip": "true",
95+
"//command_line_option:build_python_zip": str(build_python_zip),
9696
labels.BUILD_PYTHON_ZIP: build_python_zip,
9797
"//command_line_option:extra_toolchains": CC_TOOLCHAIN,
9898
"//command_line_option:platforms": str(platform_targets.WINDOWS_X86_64),

0 commit comments

Comments
 (0)