chore: make pipstar non-switchable (#3737)

The pipstar code has been there for some time and might be stable enough
to not
have a fallback anymore.

Related #2949

---------

Co-authored-by: Richard Levasseur <rlevasseur@google.com>

Author: aignas

docs/environment-variables.md

@@ -52,32 +52,6 @@ When `1`, `rules_python` will warn users about deprecated functionality that wil
 be removed in a subsequent major `rules_python` version. Defaults to `0` if unset.
 :::
 
-::::{envvar} RULES_PYTHON_ENABLE_PYSTAR
-
-When `1`, the `rules_python` Starlark implementation of the core rules is used
-instead of the Bazel-builtin rules. Note that this requires Bazel 7+. Defaults
-to `1`.
-
-:::{versionadded} 0.26.0
-Defaults to `0` if unspecified.
-:::
-:::{versionchanged} 0.40.0
-The default became `1` if unspecified
-:::
-::::
-
-::::{envvar} RULES_PYTHON_ENABLE_PIPSTAR
-
-When `1`, the `rules_python` Starlark implementation of the PyPI/pip integration is used
-instead of the legacy Python scripts.
-
-:::{versionadded} 1.5.0
-:::
-:::{versionchanged} 1.7.0
-Flipped to be enabled by default.
-:::
-::::
-
 ::::{envvar} RULES_PYTHON_EXTRACT_ROOT
 
 Directory to use as the root for creating files necessary for bootstrapping so
@@ -174,3 +148,14 @@ os, arch values are the same as the ones mentioned in the
 
 When `1`, debug information about coverage behavior is printed to stderr.
 :::
+
+## Removed Environment Variables
+
+:::{versionremoved} VERSION_NEXT_FEATURE
+The following environment variables were removed:
+
+* `RULES_PYTHON_ENABLE_PYSTAR`: Used to enable the Starlark implementation of
+  core rules.
+* `RULES_PYTHON_ENABLE_PIPSTAR`: Used to enable the Starlark implementation of
+  PyPI integration.
+:::

docs/readthedocs_build.sh

@@ -12,10 +12,7 @@ done < <(env -0)
 # In order to get the build number, we extract it from the host name
 extra_env+=("--@sphinxdocs//sphinxdocs:extra_env=HOSTNAME=$HOSTNAME")
 
-export RULES_PYTHON_ENABLE_PIPSTAR=1
-
 set -x
-export RULES_PYTHON_ENABLE_PIPSTAR=1
 bazel run \
   --config=rtd \
   "--@sphinxdocs//sphinxdocs:extra_defines=version=$READTHEDOCS_VERSION" \

examples/pip_parse_vendored/.bazelversion

@@ -0,0 +1 @@
+7.x

python/private/internal_config_repo.bzl

@@ -21,8 +21,6 @@ settings for rules to later use.
 load("//python/private:text_util.bzl", "render")
 load(":repo_utils.bzl", "repo_utils")
 
-_ENABLE_PIPSTAR_ENVVAR_NAME = "RULES_PYTHON_ENABLE_PIPSTAR"
-_ENABLE_PIPSTAR_DEFAULT = "1"
 _ENABLE_DEPRECATION_WARNINGS_ENVVAR_NAME = "RULES_PYTHON_DEPRECATION_WARNINGS"
 _ENABLE_DEPRECATION_WARNINGS_DEFAULT = "0"
 
@@ -31,7 +29,6 @@ config = struct(
   build_python_zip_default = {build_python_zip_default},
   supports_whl_extraction = {supports_whl_extraction},
   enable_pystar = True,
-  enable_pipstar = {enable_pipstar},
   enable_deprecation_warnings = {enable_deprecation_warnings},
   bazel_8_or_later = {bazel_8_or_later},
   bazel_9_or_later = {bazel_9_or_later},
@@ -104,7 +101,6 @@ def _internal_config_repo_impl(rctx):
 
     rctx.file("rules_python_config.bzl", _CONFIG_TEMPLATE.format(
         build_python_zip_default = repo_utils.get_platforms_os_name(rctx) == "windows",
-        enable_pipstar = _bool_from_environ(rctx, _ENABLE_PIPSTAR_ENVVAR_NAME, _ENABLE_PIPSTAR_DEFAULT),
         enable_deprecation_warnings = _bool_from_environ(rctx, _ENABLE_DEPRECATION_WARNINGS_ENVVAR_NAME, _ENABLE_DEPRECATION_WARNINGS_DEFAULT),
         builtin_py_info_symbol = builtin_py_info_symbol,
         builtin_py_runtime_info_symbol = builtin_py_runtime_info_symbol,
@@ -139,7 +135,7 @@ def _internal_config_repo_impl(rctx):
 internal_config_repo = repository_rule(
     implementation = _internal_config_repo_impl,
     configure = True,
-    environ = [_ENABLE_PIPSTAR_ENVVAR_NAME],
+    environ = [],
     attrs = {
         "transition_setting_generators": attr.string_list_dict(),
         "transition_settings": attr.string_list(),

python/private/pypi/BUILD.bazel

@@ -113,15 +113,13 @@ bzl_library(
         ":deps_bzl",
         ":pep508_evaluate_bzl",
         ":pep508_requirement_bzl",
-        ":pypi_repo_utils_bzl",
     ],
 )
 
 bzl_library(
     name = "extension_bzl",
     srcs = ["extension.bzl"],
     deps = [
-        ":evaluate_markers_bzl",
         ":hub_builder_bzl",
         ":hub_repository_bzl",
         ":parse_whl_name_bzl",
@@ -331,6 +329,7 @@ bzl_library(
         ":attrs_bzl",
         ":evaluate_markers_bzl",
         ":parse_requirements_bzl",
+        ":pep508_env_bzl",
         ":pip_repository_attrs_bzl",
         ":pypi_repo_utils_bzl",
         ":render_pkg_aliases_bzl",

python/private/pypi/attrs.bzl

@@ -118,39 +118,6 @@ Warning:
   If a dependency participates in multiple cycles, all of those cycles must be
   collapsed down to one. For instance `a <-> b` and `a <-> c` cannot be listed
   as two separate cycles.
-""",
-    ),
-    "experimental_target_platforms": attr.string_list(
-        default = [],
-        doc = """\
-*NOTE*: This will be removed in the next major version, so please consider migrating
-to `bzlmod` and rely on {attr}`pip.parse.requirements_by_platform` for this feature.
-
-A list of platforms that we will generate the conditional dependency graph for
-cross platform wheels by parsing the wheel metadata. This will generate the
-correct dependencies for packages like `sphinx` or `pylint`, which include
-`colorama` when installed and used on Windows platforms.
-
-An empty list means falling back to the legacy behaviour where the host
-platform is the target platform.
-
-WARNING: It may not work as expected in cases where the python interpreter
-implementation that is being used at runtime is different between different platforms.
-This has been tested for CPython only.
-
-For specific target platforms use values of the form `<os>_<arch>` where `<os>`
-is one of `linux`, `osx`, `windows` and arch is one of `x86_64`, `x86_32`,
-`aarch64`, `s390x` and `ppc64le`.
-
-You can also target a specific Python version by using `cp3<minor_version>_<os>_<arch>`.
-If multiple python versions are specified as target platforms, then select statements
-of the `lib` and `whl` targets will include usage of version aware toolchain config
-settings like `@rules_python//python/config_settings:is_python_3.y`.
-
-Special values: `host` (for generating deps for the host platform only) and
-`<prefix>_*` values. For example, `cp39_*`, `linux_*`, `cp39_linux_*`.
-
-NOTE: this is not for cross-compiling Python wheels but rather for parsing the `whl` METADATA correctly.
 """,
     ),
     "extra_hub_aliases": attr.string_list_dict(

python/private/pypi/evaluate_markers.bzl

@@ -14,19 +14,8 @@
 
 """A simple function that evaluates markers using a python interpreter."""
 
-load(":deps.bzl", "record_files")
 load(":pep508_evaluate.bzl", "evaluate")
 load(":pep508_requirement.bzl", "requirement")
-load(":pypi_repo_utils.bzl", "pypi_repo_utils")
-
-# Used as a default value in a rule to ensure we fetch the dependencies.
-SRCS = [
-    # When the version, or any of the files in `packaging` package changes,
-    # this file will change as well.
-    record_files["pypi__packaging"],
-    Label("//python/private/pypi/requirements_parser:resolve_target_platforms.py"),
-    Label("//python/private/pypi/whl_installer:platform.py"),
-]
 
 def evaluate_markers(*, requirements, platforms):
     """Return the list of supported platforms per requirements line.
@@ -51,57 +40,3 @@ def evaluate_markers(*, requirements, platforms):
                 ret.setdefault(req_string, []).append(platform_str)
 
     return ret
-
-def evaluate_markers_py(mrctx, *, requirements, python_interpreter, python_interpreter_target, srcs, logger = None):
-    """Return the list of supported platforms per requirements line.
-
-    Args:
-        mrctx: repository_ctx or module_ctx.
-        requirements: {type}`dict[str, list[str]]` of the requirement file lines to evaluate.
-        python_interpreter: str, path to the python_interpreter to use to
-            evaluate the env markers in the given requirements files. It will
-            be only called if the requirements files have env markers. This
-            should be something that is in your PATH or an absolute path.
-        python_interpreter_target: Label, same as python_interpreter, but in a
-            label format.
-        srcs: list[Label], the value of SRCS passed from the `rctx` or `mctx` to this function.
-        logger: repo_utils.logger or None, a simple struct to log diagnostic
-            messages. Defaults to None.
-
-    Returns:
-        dict of string lists with target platforms
-    """
-    if not requirements:
-        return {}
-
-    in_file = mrctx.path("requirements_with_markers.in.json")
-    out_file = mrctx.path("requirements_with_markers.out.json")
-    mrctx.file(in_file, json.encode(requirements))
-
-    interpreter = pypi_repo_utils.resolve_python_interpreter(
-        mrctx,
-        python_interpreter = python_interpreter,
-        python_interpreter_target = python_interpreter_target,
-    )
-
-    pypi_repo_utils.execute_checked(
-        mrctx,
-        op = "ResolveRequirementEnvMarkers({})".format(in_file),
-        python = interpreter,
-        arguments = [
-            "-m",
-            "python.private.pypi.requirements_parser.resolve_target_platforms",
-            in_file,
-            out_file,
-        ],
-        srcs = srcs,
-        environment = {
-            "PYTHONHOME": str(interpreter.dirname),
-            "PYTHONPATH": [
-                Label("@pypi__packaging//:BUILD.bazel"),
-                Label("//:BUILD.bazel"),
-            ],
-        },
-        logger = logger,
-    )
-    return json.decode(mrctx.read(out_file))

python/private/pypi/extension.bzl

@@ -20,7 +20,6 @@ load("@rules_python_internal//:rules_python_config.bzl", rp_config = "config")
 load("//python/private:auth.bzl", "AUTH_ATTRS")
 load("//python/private:normalize_name.bzl", "normalize_name")
 load("//python/private:repo_utils.bzl", "repo_utils")
-load(":evaluate_markers.bzl", EVALUATE_MARKERS_SRCS = "SRCS")
 load(":hub_builder.bzl", "hub_builder")
 load(":hub_repository.bzl", "hub_repository", "whl_config_settings_to_json")
 load(":parse_whl_name.bzl", "parse_whl_name")
@@ -71,14 +70,11 @@ def _configure(config, *, override = False, **kwargs):
 def build_config(
         *,
         module_ctx,
-        enable_pipstar,
         enable_pipstar_extract):
     """Parse 'configure' and 'default' extension tags
 
     Args:
         module_ctx: {type}`module_ctx` module context.
-        enable_pipstar: {type}`bool` a flag to enable dropping Python dependency for
-            evaluation of the extension.
         enable_pipstar_extract: {type}`bool | None` a flag to also not pass Python
             interpreter to `whl_library` when possible.
 
@@ -132,24 +128,20 @@ def build_config(
             name: _plat(**values)
             for name, values in defaults["platforms"].items()
         },
-        enable_pipstar = enable_pipstar,
         enable_pipstar_extract = enable_pipstar_extract,
     )
 
 def parse_modules(
         module_ctx,
         _fail = fail,
         simpleapi_download = simpleapi_download,
-        enable_pipstar = False,
         enable_pipstar_extract = False,
         **kwargs):
     """Implementation of parsing the tag classes for the extension and return a struct for registering repositories.
 
     Args:
         module_ctx: {type}`module_ctx` module context.
         simpleapi_download: Used for testing overrides
-        enable_pipstar: {type}`bool` a flag to enable dropping Python dependency for
-            evaluation of the extension.
         enable_pipstar_extract: {type}`bool` a flag to enable dropping Python dependency for
             extracting wheels.
         _fail: {type}`function` the failure function, mainly for testing.
@@ -189,7 +181,7 @@ You cannot use both the additive_build_content and additive_build_content_file a
                 srcs_exclude_glob = whl_mod.srcs_exclude_glob,
             )
 
-    config = build_config(module_ctx = module_ctx, enable_pipstar = enable_pipstar, enable_pipstar_extract = enable_pipstar_extract)
+    config = build_config(module_ctx = module_ctx, enable_pipstar_extract = enable_pipstar_extract)
 
     # TODO @aignas 2025-06-03: Merge override API with the builder?
     _overriden_whl_set = {}
@@ -377,8 +369,7 @@ def _pip_impl(module_ctx):
 
     mods = parse_modules(
         module_ctx,
-        enable_pipstar = rp_config.enable_pipstar,
-        enable_pipstar_extract = rp_config.enable_pipstar and rp_config.bazel_8_or_later,
+        enable_pipstar_extract = rp_config.bazel_8_or_later,
     )
 
     # Build all of the wheel modifications if the tag class is called.
@@ -447,10 +438,6 @@ Supported keys:
 * `platform_system`, defaults to a value inferred from the {attr}`os_name`.
 * `platform_version`, defaults to `0`.
 * `sys_platform`, defaults to a value inferred from the {attr}`os_name`.
-
-::::{note}
-This is only used if the {envvar}`RULES_PYTHON_ENABLE_PIPSTAR` is enabled.
-::::
 """,
     ),
     "index_url": attr.string(
@@ -716,13 +703,6 @@ a string `"{os}_{arch}"` as the value here. You could also use `"{os}_{arch}_fre
             doc = """\
 A dict of labels to wheel names that is typically generated by the whl_modifications.
 The labels are JSON config files describing the modifications.
-""",
-        ),
-        "_evaluate_markers_srcs": attr.label_list(
-            default = EVALUATE_MARKERS_SRCS,
-            doc = """\
-The list of labels to use as SRCS for the marker evaluation code. This ensures that the
-code will be re-evaluated when any of files in the default changes.
 """,
         ),
     }, **ATTRS)