chore: make pipstar non-switchable

At the same time cleanup pystar env var docs. Also cleanup dead code.

Author: aignas

docs/environment-variables.md

@@ -52,32 +52,6 @@ When `1`, `rules_python` will warn users about deprecated functionality that wil
 be removed in a subsequent major `rules_python` version. Defaults to `0` if unset.
 :::
 
-::::{envvar} RULES_PYTHON_ENABLE_PYSTAR
-
-When `1`, the `rules_python` Starlark implementation of the core rules is used
-instead of the Bazel-builtin rules. Note that this requires Bazel 7+. Defaults
-to `1`.
-
-:::{versionadded} 0.26.0
-Defaults to `0` if unspecified.
-:::
-:::{versionchanged} 0.40.0
-The default became `1` if unspecified
-:::
-::::
-
-::::{envvar} RULES_PYTHON_ENABLE_PIPSTAR
-
-When `1`, the `rules_python` Starlark implementation of the PyPI/pip integration is used
-instead of the legacy Python scripts.
-
-:::{versionadded} 1.5.0
-:::
-:::{versionchanged} 1.7.0
-Flipped to be enabled by default.
-:::
-::::
-
 ::::{envvar} RULES_PYTHON_EXTRACT_ROOT
 
 Directory to use as the root for creating files necessary for bootstrapping so

docs/readthedocs_build.sh

@@ -12,10 +12,7 @@ done < <(env -0)
 # In order to get the build number, we extract it from the host name
 extra_env+=("--@sphinxdocs//sphinxdocs:extra_env=HOSTNAME=$HOSTNAME")
 
-export RULES_PYTHON_ENABLE_PIPSTAR=1
-
 set -x
-export RULES_PYTHON_ENABLE_PIPSTAR=1
 bazel run \
   --config=rtd \
   "--@sphinxdocs//sphinxdocs:extra_defines=version=$READTHEDOCS_VERSION" \

python/private/internal_config_repo.bzl

@@ -21,8 +21,6 @@ settings for rules to later use.
 load("//python/private:text_util.bzl", "render")
 load(":repo_utils.bzl", "repo_utils")
 
-_ENABLE_PIPSTAR_ENVVAR_NAME = "RULES_PYTHON_ENABLE_PIPSTAR"
-_ENABLE_PIPSTAR_DEFAULT = "1"
 _ENABLE_DEPRECATION_WARNINGS_ENVVAR_NAME = "RULES_PYTHON_DEPRECATION_WARNINGS"
 _ENABLE_DEPRECATION_WARNINGS_DEFAULT = "0"
 
@@ -31,7 +29,6 @@ config = struct(
   build_python_zip_default = {build_python_zip_default},
   supports_whl_extraction = {supports_whl_extraction},
   enable_pystar = True,
-  enable_pipstar = {enable_pipstar},
   enable_deprecation_warnings = {enable_deprecation_warnings},
   bazel_8_or_later = {bazel_8_or_later},
   bazel_9_or_later = {bazel_9_or_later},
@@ -104,7 +101,6 @@ def _internal_config_repo_impl(rctx):
 
     rctx.file("rules_python_config.bzl", _CONFIG_TEMPLATE.format(
         build_python_zip_default = repo_utils.get_platforms_os_name(rctx) == "windows",
-        enable_pipstar = _bool_from_environ(rctx, _ENABLE_PIPSTAR_ENVVAR_NAME, _ENABLE_PIPSTAR_DEFAULT),
         enable_deprecation_warnings = _bool_from_environ(rctx, _ENABLE_DEPRECATION_WARNINGS_ENVVAR_NAME, _ENABLE_DEPRECATION_WARNINGS_DEFAULT),
         builtin_py_info_symbol = builtin_py_info_symbol,
         builtin_py_runtime_info_symbol = builtin_py_runtime_info_symbol,
@@ -139,7 +135,7 @@ def _internal_config_repo_impl(rctx):
 internal_config_repo = repository_rule(
     implementation = _internal_config_repo_impl,
     configure = True,
-    environ = [_ENABLE_PIPSTAR_ENVVAR_NAME],
+    environ = [],
     attrs = {
         "transition_setting_generators": attr.string_list_dict(),
         "transition_settings": attr.string_list(),

python/private/pypi/extension.bzl

@@ -71,14 +71,11 @@ def _configure(config, *, override = False, **kwargs):
 def build_config(
         *,
         module_ctx,
-        enable_pipstar,
         enable_pipstar_extract):
     """Parse 'configure' and 'default' extension tags
 
     Args:
         module_ctx: {type}`module_ctx` module context.
-        enable_pipstar: {type}`bool` a flag to enable dropping Python dependency for
-            evaluation of the extension.
         enable_pipstar_extract: {type}`bool | None` a flag to also not pass Python
             interpreter to `whl_library` when possible.
 
@@ -132,24 +129,20 @@ def build_config(
             name: _plat(**values)
             for name, values in defaults["platforms"].items()
         },
-        enable_pipstar = enable_pipstar,
         enable_pipstar_extract = enable_pipstar_extract,
     )
 
 def parse_modules(
         module_ctx,
         _fail = fail,
         simpleapi_download = simpleapi_download,
-        enable_pipstar = False,
         enable_pipstar_extract = False,
         **kwargs):
     """Implementation of parsing the tag classes for the extension and return a struct for registering repositories.
 
     Args:
         module_ctx: {type}`module_ctx` module context.
         simpleapi_download: Used for testing overrides
-        enable_pipstar: {type}`bool` a flag to enable dropping Python dependency for
-            evaluation of the extension.
         enable_pipstar_extract: {type}`bool` a flag to enable dropping Python dependency for
             extracting wheels.
         _fail: {type}`function` the failure function, mainly for testing.
@@ -189,7 +182,7 @@ You cannot use both the additive_build_content and additive_build_content_file a
                 srcs_exclude_glob = whl_mod.srcs_exclude_glob,
             )
 
-    config = build_config(module_ctx = module_ctx, enable_pipstar = enable_pipstar, enable_pipstar_extract = enable_pipstar_extract)
+    config = build_config(module_ctx = module_ctx, enable_pipstar_extract = enable_pipstar_extract)
 
     # TODO @aignas 2025-06-03: Merge override API with the builder?
     _overriden_whl_set = {}
@@ -377,8 +370,7 @@ def _pip_impl(module_ctx):
 
     mods = parse_modules(
         module_ctx,
-        enable_pipstar = rp_config.enable_pipstar,
-        enable_pipstar_extract = rp_config.enable_pipstar and rp_config.bazel_8_or_later,
+        enable_pipstar_extract = rp_config.bazel_8_or_later,
     )
 
     # Build all of the wheel modifications if the tag class is called.
@@ -447,10 +439,6 @@ Supported keys:
 * `platform_system`, defaults to a value inferred from the {attr}`os_name`.
 * `platform_version`, defaults to `0`.
 * `sys_platform`, defaults to a value inferred from the {attr}`os_name`.
-
-::::{note}
-This is only used if the {envvar}`RULES_PYTHON_ENABLE_PIPSTAR` is enabled.
-::::
 """,
     ),
     "index_url": attr.string(

python/private/pypi/hub_builder.bzl

@@ -7,7 +7,7 @@ load("//python/private:text_util.bzl", "render")
 load("//python/private:version.bzl", "version")
 load("//python/private:version_label.bzl", "version_label")
 load(":attrs.bzl", "use_isolated")
-load(":evaluate_markers.bzl", "evaluate_markers_py", evaluate_markers_star = "evaluate_markers")
+load(":evaluate_markers.bzl", evaluate_markers_star = "evaluate_markers")
 load(":parse_requirements.bzl", "parse_requirements")
 load(":pep508_env.bzl", "env")
 load(":pep508_evaluate.bzl", "evaluate")
@@ -194,7 +194,6 @@ def _pip_parse(self, module_ctx, pip_attr):
         self,
         module_ctx,
         pip_attr = pip_attr,
-        enable_pipstar = bool(self._config.enable_pipstar or self._get_index_urls.get(pip_attr.python_version)),
         enable_pipstar_extract = bool(self._config.enable_pipstar_extract or self._get_index_urls.get(pip_attr.python_version)),
     )
 
@@ -297,24 +296,21 @@ def _diff_dict(first, second):
     else:
         return None
 
-def _add_whl_library(self, *, python_version, whl, repo, enable_pipstar):
+def _add_whl_library(self, *, python_version, whl, repo):
     """Add a whl_library and kwargs to call it with for the hub.
 
     Args:
         self: implicitly added
         python_version: {type}`str` the python version to assume
         whl: struct from `_whl_library_args()`
         repo: struct from `_whl_repo`
-        enable_pipstar: {type}`bool` if pipstar is enabled.
     """
     if repo == None:
         # NOTE @aignas 2025-07-07: we guard against an edge-case where there
         # are more platforms defined than there are wheels for and users
         # disallow building from sdist.
         return
 
-    platforms = self._platforms[python_version]
-
     # TODO @aignas 2025-06-29: we should not need the version in the repo_name if
     # we are using pipstar and we are downloading the wheel using the downloader
     #
@@ -339,17 +335,6 @@ def _add_whl_library(self, *, python_version, whl, repo, enable_pipstar):
             return
     self._whl_libraries[repo_name] = repo.args
 
-    if not enable_pipstar and "experimental_target_platforms" in repo.args:
-        self._whl_libraries[repo_name] |= {
-            "experimental_target_platforms": sorted({
-                # TODO @aignas 2025-07-07: this should be solved in a better way
-                platforms[candidate].triple.partition("_")[-1]: None
-                for p in repo.args["experimental_target_platforms"]
-                for candidate in platforms
-                if candidate.endswith(p)
-            }),
-        }
-
     mapping = self._whl_map.setdefault(whl.name, {})
     if repo.config_setting in mapping and mapping[repo.config_setting] != repo_name:
         fail(
@@ -480,61 +465,27 @@ def _platforms(module_ctx, *, python_version, config, target_platforms):
         )
     return platforms
 
-def _evaluate_markers(self, pip_attr, enable_pipstar):
+def _evaluate_markers(self, pip_attr):
     if self._evaluate_markers_fn:
         return self._evaluate_markers_fn
 
-    if enable_pipstar:
-        return lambda _, requirements: evaluate_markers_star(
-            requirements = requirements,
-            platforms = self._platforms[pip_attr.python_version],
-        )
-
-    interpreter = _detect_interpreter(self, pip_attr)
-
-    # NOTE @aignas 2024-08-02: , we will execute any interpreter that we find either
-    # in the PATH or if specified as a label. We will configure the env
-    # markers when evaluating the requirement lines based on the output
-    # from the `requirements_files_by_platform` which should have something
-    # similar to:
-    # {
-    #    "//:requirements.txt": ["cp311_linux_x86_64", ...]
-    # }
-    #
-    # We know the target python versions that we need to evaluate the
-    # markers for and thus we don't need to use multiple python interpreter
-    # instances to perform this manipulation. This function should be executed
-    # only once by the underlying code to minimize the overhead needed to
-    # spin up a Python interpreter.
-    return lambda module_ctx, requirements: evaluate_markers_py(
-        module_ctx,
-        requirements = {
-            k: {
-                p: self._platforms[pip_attr.python_version][p].triple
-                for p in plats
-            }
-            for k, plats in requirements.items()
-        },
-        python_interpreter = interpreter.path,
-        python_interpreter_target = interpreter.target,
-        srcs = pip_attr._evaluate_markers_srcs,
-        logger = self._logger,
+    return lambda _, requirements: evaluate_markers_star(
+        requirements = requirements,
+        platforms = self._platforms[pip_attr.python_version],
     )
 
 def _create_whl_repos(
         self,
         module_ctx,
         *,
         pip_attr,
-        enable_pipstar = False,
         enable_pipstar_extract = False):
     """create all of the whl repositories
 
     Args:
         self: the builder.
         module_ctx: {type}`module_ctx`.
         pip_attr: {type}`struct` - the struct that comes from the tag class iteration.
-        enable_pipstar: {type}`bool` - enable the pipstar or not.
         enable_pipstar_extract: {type}`bool` - enable the pipstar extraction or not.
     """
     logger = self._logger
@@ -558,7 +509,7 @@ def _create_whl_repos(
         platforms = platforms,
         extra_pip_args = pip_attr.extra_pip_args,
         get_index_urls = self._get_index_urls.get(pip_attr.python_version),
-        evaluate_markers = _evaluate_markers(self, pip_attr, enable_pipstar),
+        evaluate_markers = _evaluate_markers(self, pip_attr),
         logger = logger,
     )
 
@@ -577,7 +528,6 @@ def _create_whl_repos(
         self,
         module_ctx,
         pip_attr = pip_attr,
-        enable_pipstar = enable_pipstar,
     )
 
     interpreter = _detect_interpreter(self, pip_attr)
@@ -600,18 +550,16 @@ def _create_whl_repos(
                 python_version = _major_minor_version(pip_attr.python_version),
                 is_multiple_versions = whl.is_multiple_versions,
                 interpreter = interpreter,
-                enable_pipstar = enable_pipstar,
                 enable_pipstar_extract = enable_pipstar_extract,
             )
             _add_whl_library(
                 self,
                 python_version = pip_attr.python_version,
                 whl = whl,
                 repo = repo,
-                enable_pipstar = enable_pipstar,
             )
 
-def _common_args(self, module_ctx, *, pip_attr, enable_pipstar):
+def _common_args(self, module_ctx, *, pip_attr):
     # Construct args separately so that the lock file can be smaller and does not include unused
     # attrs.
     whl_library_args = dict(
@@ -627,8 +575,6 @@ def _common_args(self, module_ctx, *, pip_attr, enable_pipstar):
         envsubst = pip_attr.envsubst,
         pip_data_exclude = pip_attr.pip_data_exclude,
     )
-    if not enable_pipstar:
-        maybe_args["experimental_target_platforms"] = pip_attr.experimental_target_platforms
 
     whl_library_args.update({k: v for k, v in maybe_args.items() if v})
     maybe_args_with_default = dict(
@@ -679,7 +625,6 @@ def _whl_repo(
         python_version,
         use_downloader,
         interpreter,
-        enable_pipstar = False,
         enable_pipstar_extract = False):
     args = dict(whl_library_args)
     args["requirement"] = src.requirement_line
@@ -731,14 +676,6 @@ def _whl_repo(
     args["urls"] = [src.url]
     args["sha256"] = src.sha256
     args["filename"] = src.filename
-    if not enable_pipstar:
-        args["experimental_target_platforms"] = [
-            # Get rid of the version for the target platforms because we are
-            # passing the interpreter any way. Ideally we should search of ways
-            # how to pass the target platforms through the hub repo.
-            p.partition("_")[2]
-            for p in src.target_platforms
-        ]
 
     # TODO @aignas 2025-11-02: once we have pipstar enabled we can add extra
     # targets to each hub for each extra combination and solve this more cleanly as opposed to

python/private/pypi/whl_installer/arguments.py

@@ -47,11 +47,6 @@ def parser(**kwargs: Any) -> argparse.ArgumentParser:
         type=Platform.from_string,
         help="Platforms to target dependencies. Can be used multiple times.",
     )
-    parser.add_argument(
-        "--enable-pipstar",
-        action="store_true",
-        help="Disable certain code paths if we expect to process the whl in Starlark.",
-    )
     parser.add_argument(
         "--pip_data_exclude",
         action="store",