Skip to content

Commit 5050f4f

Browse files
committed
Respond to AI feedback
1 parent 3e48c89 commit 5050f4f

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

python/private/pypi/pep508_deps.bzl

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ def deps(
8181
deps_select = {
8282
d: markers
8383
for d, markers in sorted(deps_select.items())
84-
if d not in deps
8584
},
8685
)
8786

@@ -157,17 +156,21 @@ def _add_reqs(deps, deps_select, dep, reqs, *, extras):
157156
return
158157

159158
markers = {}
159+
found_unconditional = False
160160
for req in reqs:
161161
for x in extras:
162162
m = evaluate(req.marker, env = {"extra": x}, strict = False)
163163
if m == False:
164164
continue
165165
elif m == True:
166166
_add(deps, deps_select, dep)
167+
found_unconditional = True
167168
break
168169
else:
169170
markers[m] = None
170171
continue
172+
if found_unconditional:
173+
break
171174

172-
if markers:
175+
if markers and not found_unconditional:
173176
_add(deps, deps_select, dep, sorted(markers))

0 commit comments

Comments
 (0)