pre-commit run ruff-check -a

aignas · aignas · commit 58190f7db149 · 2026-05-23T14:43:56.000+09:00
diff --git a/docs/conf.py b/docs/conf.py
@@ -133,11 +133,11 @@
 # --- Extlinks configuration
 extlinks = {
     "gh-issue": (
-        f"https://github.com/bazel-contrib/rules_python/issues/%s",
+        "https://github.com/bazel-contrib/rules_python/issues/%s",
         "#%s issue",
     ),
-    "gh-path": (f"https://github.com/bazel-contrib/rules_python/tree/main/%s", "%s"),
-    "gh-pr": (f"https://github.com/bazel-contrib/rules_python/pull/%s", "#%s PR"),
+    "gh-path": ("https://github.com/bazel-contrib/rules_python/tree/main/%s", "%s"),
+    "gh-pr": ("https://github.com/bazel-contrib/rules_python/pull/%s", "#%s PR"),
 }
 
 # --- MyST configuration
diff --git a/examples/bzlmod/entry_points/tests/pylint_deps_test.py b/examples/bzlmod/entry_points/tests/pylint_deps_test.py
@@ -15,7 +15,6 @@
 import os
 import pathlib
 import subprocess
-import tempfile
 import unittest
 
 from python.runfiles import runfiles
diff --git a/examples/bzlmod/test.py b/examples/bzlmod/test.py
@@ -13,7 +13,6 @@
 # limitations under the License.
 
 import os
-import pathlib
 import re
 import sys
 import unittest
diff --git a/examples/bzlmod/tests/my_lib_test.py b/examples/bzlmod/tests/my_lib_test.py
@@ -12,7 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import os
 import sys
 
 import libs.my_lib as my_lib
diff --git a/examples/multi_python_versions/tests/my_lib_test.py b/examples/multi_python_versions/tests/my_lib_test.py
@@ -12,7 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import os
 import sys
 
 import libs.my_lib as my_lib
diff --git a/gazelle/manifest/copy_to_source.py b/gazelle/manifest/copy_to_source.py
@@ -6,7 +6,6 @@
 
 import os
 import shutil
-import stat
 import sys
 from pathlib import Path
 
diff --git a/python/private/py_console_script_gen.py b/python/private/py_console_script_gen.py
@@ -37,9 +37,6 @@
 import argparse
 import configparser
 import pathlib
-import re
-import sys
-import textwrap
 
 _ENTRY_POINTS_TXT = "entry_points.txt"
 
diff --git a/python/private/pypi/repack_whl.py b/python/private/pypi/repack_whl.py
@@ -174,7 +174,7 @@ def main(sys_argv):
                 rel_path = p.relative_to(patched_wheel_dir)
                 out.add_file(str(rel_path), p)
 
-            logging.debug(f"Writing RECORD file")
+            logging.debug("Writing RECORD file")
             got_record = out.add_recordfile()
 
     if got_record == record_contents:
diff --git a/python/private/pypi/whl_installer/arguments.py b/python/private/pypi/whl_installer/arguments.py
@@ -14,7 +14,6 @@
 
 import argparse
 import json
-import pathlib
 from typing import Any, Dict, Set
 
 
diff --git a/python/private/pypi/whl_installer/wheel_installer.py b/python/private/pypi/whl_installer/wheel_installer.py
@@ -18,12 +18,10 @@
 import glob
 import json
 import os
-import re
 import subprocess
 import sys
 from pathlib import Path
 from tempfile import NamedTemporaryFile
-from typing import Dict, List, Optional, Set, Tuple
 
 from python.private.pypi.whl_installer import arguments
 
diff --git a/python/private/stage2_bootstrap_template.py b/python/private/stage2_bootstrap_template.py
@@ -356,7 +356,6 @@ def _maybe_collect_coverage(enable):
     print_verbose_coverage("Instrumented Files:\n" + "\n".join(instrumented_files))
     print_verbose_coverage("Sources:\n" + "\n".join(unique_dirs))
 
-    import uuid
 
     import coverage
 
diff --git a/python/runfiles/runfiles.py b/python/runfiles/runfiles.py
@@ -23,14 +23,13 @@
 :::
 """
 
-import collections.abc
 import inspect
 import os
 import pathlib
 import posixpath
 import sys
 from collections import defaultdict
-from typing import Dict, Generator, Iterable, List, Optional, Tuple, Union
+from typing import Dict, Generator, Optional, Tuple, Union
 
 if sys.version_info >= (3, 11):
     from typing import Self
diff --git a/sphinxdocs/sphinxdocs/private/proto_to_markdown.py b/sphinxdocs/sphinxdocs/private/proto_to_markdown.py
@@ -13,11 +13,9 @@
 # limitations under the License.
 
 import argparse
-import io
 import itertools
 import pathlib
 import sys
-import textwrap
 from typing import Callable, TextIO, TypeVar
 
 from stardoc.proto import stardoc_output_pb2
diff --git a/sphinxdocs/sphinxdocs/private/sphinx_server.py b/sphinxdocs/sphinxdocs/private/sphinx_server.py
@@ -24,7 +24,7 @@ def __init__(self, *args, **kwargs):
     with _start_server(DirectoryHandler, "0.0.0.0", 8000) as (ip, port, httpd):
 
         def _print_server_info():
-            print(f"Serving...")
+            print("Serving...")
             print(f"  Address: http://{ip}:{port}")
             print(f"  Serving directory: {serve_directory}")
             print(f"      url: file://{serve_directory}")
diff --git a/sphinxdocs/tests/proto_to_markdown/proto_to_markdown_test.py b/sphinxdocs/tests/proto_to_markdown/proto_to_markdown_test.py
@@ -13,7 +13,6 @@
 # limitations under the License.
 
 import io
-import re
 
 from absl.testing import absltest
 from google.protobuf import text_format
diff --git a/tests/bootstrap_impls/call_sys_exe.py b/tests/bootstrap_impls/call_sys_exe.py
@@ -12,7 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import os
 import subprocess
 import sys
 
diff --git a/tests/bootstrap_impls/system_python_nodeps_test.py b/tests/bootstrap_impls/system_python_nodeps_test.py
@@ -8,4 +8,3 @@
 # Verify a C-implemented module can be imported.
 # Socket isn't implement in C, but requires `_socket`,
 # which is implemented in C
-import socket
diff --git a/tests/cc/current_py_cc_headers/abi3_headers_linkage_test.py b/tests/cc/current_py_cc_headers/abi3_headers_linkage_test.py
@@ -1,5 +1,3 @@
-import os.path
-import pathlib
 import sys
 import unittest
 
diff --git a/tests/integration/custom_commands_test.py b/tests/integration/custom_commands_test.py
@@ -12,7 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import logging
 import unittest
 
 from tests.integration import runner
diff --git a/tests/integration/local_toolchains/repo_runtime_test.py b/tests/integration/local_toolchains/repo_runtime_test.py
@@ -1,8 +1,5 @@
 import os.path
-import shutil
-import subprocess
 import sys
-import tempfile
 import unittest
 
 
diff --git a/tests/py_zipapp/system_python_zipapp_test.py b/tests/py_zipapp/system_python_zipapp_test.py
@@ -1,7 +1,6 @@
 import os
 import subprocess
 import unittest
-import zipfile
 
 
 class SystemPythonZipAppTest(unittest.TestCase):
diff --git a/tests/repl/repl_test.py b/tests/repl/repl_test.py
@@ -1,6 +1,5 @@
 import os
 import subprocess
-import sys
 import tempfile
 import unittest
 from pathlib import Path
@@ -89,7 +88,7 @@ def test_repl_version(self):
     def test_cannot_import_test_module_directly(self):
         """Validates that we cannot import helper/test_module.py since it's not a direct dep."""
         with self.assertRaises(ModuleNotFoundError):
-            import test_module
+            pass
 
     @unittest.skipIf(
         not EXPECT_TEST_MODULE_IMPORTABLE, "test only works without repl_dep set"
diff --git a/tests/tools/private/release/release_test.py b/tests/tools/private/release/release_test.py
@@ -1,4 +1,3 @@
-import datetime
 import os
 import pathlib
 import shutil
@@ -91,9 +90,9 @@ def test_update_changelog(self):
         self.assertIn(
             _UNRELEASED_TEMPLATE, new_content, msg=f"ACTUAL:\n\n{new_content}\n\n"
         )
-        self.assertIn(f"## [1.23.4] - 2025-01-01", new_content)
+        self.assertIn("## [1.23.4] - 2025-01-01", new_content)
         self.assertIn(
-            f"[1.23.4]: https://github.com/bazel-contrib/rules_python/releases/tag/1.23.4",
+            "[1.23.4]: https://github.com/bazel-contrib/rules_python/releases/tag/1.23.4",
             new_content,
         )
         self.assertIn("{#v1-23-4}", new_content)
diff --git a/tests/tools/zipapp/zip_main_maker_test.py b/tests/tools/zipapp/zip_main_maker_test.py
@@ -36,7 +36,7 @@ def test_creates_zip_main(self):
             f.write(f"rf-file|0|file1.txt|{file1_path}\n")
             f.write(f"rf-file|0|file2.txt|{file2_path}\n")
             f.write(f"rf-symlink|1|symlink.txt|{symlink_path}\n")
-            f.write(f"rf-empty|empty_file.txt\n")
+            f.write("rf-empty|empty_file.txt\n")
 
         argv = [
             "zip_main_maker.py",
@@ -58,7 +58,7 @@ def test_creates_zip_main(self):
         line1 = f"rf-file|0|file1.txt|{file1_path}"
         line2 = f"rf-file|0|file2.txt|{file2_path}"
         line3 = f"rf-symlink|1|symlink.txt|{symlink_path}"
-        line4 = f"rf-empty|empty_file.txt"
+        line4 = "rf-empty|empty_file.txt"
 
         # Sort lines like the program does
         lines = sorted([line1, line2, line3, line4])
diff --git a/tests/tools/zipapp/zipper_test.py b/tests/tools/zipapp/zipper_test.py
@@ -2,7 +2,6 @@
 import pathlib
 import shutil
 import tempfile
-import time
 import unittest
 import zipfile
 
@@ -66,7 +65,7 @@ def test_create_zip_with_files_and_symlinks(self):
             f"rf-file|0|foo/bar.txt|{file1_path}",
             f"rf-symlink|1|link1|{symlink_path}",  # Should read target 'target.txt'
             f"rf-root-symlink|0|root_file|{file1_path}",
-            f"rf-empty|empty_file",
+            "rf-empty|empty_file",
         ]
         self.manifest_path.write_text("\n".join(manifest_content))
 
@@ -196,7 +195,7 @@ def test_runfiles_mapping_with_cross_repo_paths(self):
 
         manifest_content = [
             f"rf-file|0|../other_repo/foo.txt|{file1_path}",
-            f"rf-empty|../other_repo/empty_file",
+            "rf-empty|../other_repo/empty_file",
         ]
 
         self.manifest_path.write_text("\n".join(manifest_content))
@@ -222,7 +221,7 @@ def test_runfiles_mapping_with_legacy_external_paths(self):
 
         manifest_content = [
             f"rf-file|0|external/other_repo/foo.txt|{file1_path}",
-            f"rf-empty|external/other_repo/empty_file",
+            "rf-empty|external/other_repo/empty_file",
         ]
 
         self.manifest_path.write_text("\n".join(manifest_content))
@@ -265,7 +264,7 @@ def test_output_deterministic(self):
             f"rf-file|0|b_rf_file|{file2}",  # -> runfiles/my_ws/b_rf_file
             f"rf-root-symlink|0|a_root_link|{file3}",  # -> runfiles/a_root_link
             f"regular|0|a/regular|{file3}",
-            f"rf-empty|d_rf_empty",  # -> runfiles/my_ws/d_rf_empty
+            "rf-empty|d_rf_empty",  # -> runfiles/my_ws/d_rf_empty
             f"rf-symlink|0|c_rf_link|{file3}",  # -> runfiles/my_ws/c_rf_link
         ]
 
diff --git a/tests/uv/lock/lock_run_test.py b/tests/uv/lock/lock_run_test.py
@@ -1,5 +1,4 @@
 import subprocess
-import sys
 import tempfile
 import unittest
 from pathlib import Path
diff --git a/tests/venv_site_packages_libs/bin.py b/tests/venv_site_packages_libs/bin.py
@@ -1,5 +1,4 @@
 import importlib
-import os
 import sys
 import sysconfig
 import unittest
diff --git a/tests/whl_with_build_files/verify_files_test.py b/tests/whl_with_build_files/verify_files_test.py
@@ -6,10 +6,7 @@ def test_wheel_with_build_files_importable(self):
         # If the BUILD files are present, then these imports should fail
         # because globs won't pass package boundaries, and the necessary
         # py files end up missing in runfiles.
-        import somepkg
-        import somepkg.a
-        import somepkg.subpkg
-        import somepkg.subpkg.b
+        pass
 
 
 if __name__ == "__main__":
diff --git a/tools/private/update_deps/update_coverage_deps.py b/tools/private/update_deps/update_coverage_deps.py
@@ -20,11 +20,8 @@
 
 # NOTE @aignas 2023-01-09: We should only depend on core Python 3 packages.
 import argparse
-import difflib
 import json
 import os
-import pathlib
-import sys
 import textwrap
 from collections import defaultdict
 from dataclasses import dataclass
diff --git a/tools/private/update_deps/update_file.py b/tools/private/update_deps/update_file.py
@@ -17,10 +17,8 @@
 This is reused in other files updating coverage deps and pip deps.
 """
 
-import argparse
 import difflib
 import pathlib
-import sys
 
 
 def _writelines(path: pathlib.Path, out: str):
diff --git a/tools/private/zipapp/zipper.py b/tools/private/zipapp/zipper.py
@@ -1,7 +1,6 @@
 import argparse
 import os
 import shutil
-import stat
 import sys
 import zipfile
 from os.path import dirname
diff --git a/tools/wheelmaker.py b/tools/wheelmaker.py
@@ -24,7 +24,6 @@
 import stat
 import sys
 import zipfile
-from collections.abc import Iterable
 from pathlib import Path
 
 _ZIP_EPOCH = (1980, 1, 1, 0, 0, 0)
@@ -618,7 +617,6 @@ def main() -> None:
         # This is not imported at the top of the file due to the reliance
         # on this file in the `whl_library` repository rule which does not
         # provide `packaging` but does import symbols defined here.
-        from packaging.requirements import Requirement
 
         # Search for any `Requires-Dist` entries that refer to other files and
         # expand them.
