disable windows for zipapp tests

Author: rickeylev

python/private/common.bzl

@@ -16,6 +16,7 @@
 load("@bazel_skylib//lib:paths.bzl", "paths")
 load("@rules_cc//cc/common:cc_common.bzl", "cc_common")
 load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")
+load("@rules_python_internal//:rules_python_config.bzl", "config")
 load("//python/private:py_interpreter_program.bzl", "PyInterpreterProgramInfo")
 load("//python/private:toolchain_types.bzl", "EXEC_TOOLS_TOOLCHAIN_TYPE")
 load(":cc_helper.bzl", "cc_helper")
@@ -43,6 +44,17 @@ PYTHON_FILE_EXTENSIONS = [
     "so",  # Python C modules, usually Linux
 ]
 
+BUILTIN_BUILD_PYTHON_ZIP = [] if config.bazel_10_or_later else [
+    "//command_line_option:build_python_zip",
+]
+
+def maybe_builtin_build_python_zip(value, settings = None):
+    settings = settings or {}
+    if not config.bazel_10_or_later:
+        settings["//command_line_option:build_python_zip"] = value
+
+    return settings
+
 def create_binary_semantics_struct(
         *,
         get_native_deps_dso_name,

python/private/zipapp/py_zipapp_rule.bzl

@@ -207,16 +207,15 @@ def _transition_zipapp_impl(settings, attr):
 
     # Force this to false, otherwise the binary is already a zipapp
     settings[labels.BUILD_PYTHON_ZIP] = False
-    settings["//command_line_option:build_python_zip"] = "false"
+    maybe_builtin_build_python_zip("false", settings)
     return settings
 
 _zipapp_transition = transition(
     implementation = _transition_zipapp_impl,
     inputs = TRANSITION_LABELS,
     outputs = TRANSITION_LABELS + [
         labels.BUILD_PYTHON_ZIP,
-        "//command_line_option:build_python_zip",
-    ],
+    ] + BUILTIN_BUILD_PYTHON_ZIP,
 )
 
 _ATTRS = {

tests/py_zipapp/BUILD.bazel

@@ -2,6 +2,11 @@ load("//python:py_binary.bzl", "py_binary")
 load("//python:py_test.bzl", "py_test")
 load("//python/private:bzlmod_enabled.bzl", "BZLMOD_ENABLED")  # buildifier: disable=bzl-visibility
 load("//python/zipapp:py_zipapp_binary.bzl", "py_zipapp_binary")
+load("//tests/support:support.bzl", "NOT_WINDOWS")
+
+# todo: add windows support. Windows support will be a bit odd.
+# It previously worked by having special logic in the exe launcher
+# that knew to look for .zip and running that through python
 
 py_binary(
     name = "venv_bin",
@@ -11,12 +16,14 @@ py_binary(
         "//python/config_settings:venvs_site_packages": "yes",
     },
     main = "main.py",
+    target_compatible_with = NOT_WINDOWS,
     deps = ["@dev_pip//absl_py"],
 )
 
 py_zipapp_binary(
     name = "venv_zipapp",
     binary = ":venv_bin",
+    target_compatible_with = NOT_WINDOWS,
 )
 
 py_test(
@@ -27,6 +34,7 @@ py_test(
         "BZLMOD_ENABLED": str(int(BZLMOD_ENABLED)),
         "TEST_ZIPAPP": "$(location :venv_zipapp)",
     },
+    target_compatible_with = NOT_WINDOWS,
 )
 
 py_binary(
@@ -37,12 +45,14 @@ py_binary(
         "//python/config_settings:venvs_site_packages": "no",
     },
     main = "main.py",
+    target_compatible_with = NOT_WINDOWS,
     deps = ["@dev_pip//absl_py"],
 )
 
 py_zipapp_binary(
     name = "system_python_zipapp",
     binary = ":system_python_bin",
+    target_compatible_with = NOT_WINDOWS,
 )
 
 py_test(
@@ -52,4 +62,5 @@ py_test(
     env = {
         "TEST_ZIPAPP": "$(location :system_python_zipapp)",
     },
+    target_compatible_with = NOT_WINDOWS,
 )