Skip to content

Commit 6756f2a

Browse files
committed
fix(pip): simply extract whl contents to the current directory
Before we would try to get the whl path and extract to the sibling directory. Whilst this is not failing right now, technically this is not the best behaviour because the whl itself may come from elsewhere. This PR is simplifying code to see if it helps solve an issue on Windows. Fixes #3543
1 parent 717b943 commit 6756f2a

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,14 @@ END_UNRELEASED_TEMPLATE
8383
that are associated with the target's `srcs` are present.
8484
([#3354](https://github.com/bazel-contrib/rules_python/issues/3354)).
8585

86+
{#v1-8-3}
87+
## [1.8.3] - 2026-01-27
88+
89+
{#v1-8-3-fixed}
90+
### Fixed
91+
* (pipstar) Fix whl extraction on Windows when bazelrc has XX flags.
92+
Fixes [#3543](https://github.com/bazel-contrib/rules_python/issues/3543).
93+
8694
{#v1-8-2}
8795
## [1.8.2] - 2026-01-24
8896

python/private/pypi/whl_extract.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ def whl_extract(rctx, *, whl_path, logger):
1212
whl_path: the whl path to extract.
1313
logger: The logger to use
1414
"""
15-
install_dir_path = whl_path.dirname.get_child("site-packages")
15+
install_dir_path = rctx.path("site-packages")
1616
repo_utils.extract(
1717
rctx,
1818
archive = whl_path,

0 commit comments

Comments
 (0)