Merge branch 'main' into aignas.feat.facts.sha.versions

Author: aignas

.bazelci/presubmit.yml

@@ -282,7 +282,7 @@ tasks:
     platform: rbe_ubuntu2204
     # TODO @aignas 2024-12-11: get the RBE working in CI for bazel 8.0
     # See https://github.com/bazelbuild/rules_python/issues/2499
-    bazel: 7.x
+    bazel: 8.x
     test_flags:
       - "--test_tag_filters=-integration-test,-acceptance-test"
       - "--extra_toolchains=@buildkite_config//config:cc-toolchain"

CHANGELOG.md

@@ -83,6 +83,14 @@ END_UNRELEASED_TEMPLATE
   that are associated with the target's `srcs` are present.
   ([#3354](https://github.com/bazel-contrib/rules_python/issues/3354)).
 
+{#v1-8-3}
+## [1.8.3] - 2026-01-27
+
+{#v1-8-3-fixed}
+### Fixed
+* (pipstar) Fix whl extraction on Windows when bazelrc has XX flags.
+  Fixes [#3543](https://github.com/bazel-contrib/rules_python/issues/3543).
+
 {#v1-8-2}
 ## [1.8.2] - 2026-01-24
 

python/private/build_data_writer.ps1

@@ -1,7 +1,6 @@
 $OutputPath = $env:OUTPUT
 
 Add-Content -Path $OutputPath -Value "TARGET $env:TARGET"
-Add-Content -Path $OutputPath -Value "CONFIG_ID $env:CONFIG_ID"
 Add-Content -Path $OutputPath -Value "CONFIG_MODE $env:CONFIG_MODE"
 Add-Content -Path $OutputPath -Value "STAMPED $env:STAMPED"
 

python/private/py_executable.bzl

@@ -1369,9 +1369,17 @@ def _write_build_data(ctx):
     action_args = ctx.actions.args()
     writer_file = ctx.files._build_data_writer[0]
     if writer_file.path.endswith(".ps1"):
-        action_exe = "pwsh.exe"
-        action_args.add("-File")
-        action_args.add(writer_file)
+        # powershell.exe is used for broader compatibility
+        # It is installed by default on most Windows versions
+        action_exe = "powershell.exe"
+        action_args.add_all([
+            # Bypass execution policy is needed because,
+            # by default, Windows blocks ps1 scripts.
+            "-ExecutionPolicy",
+            "Bypass",
+            "-File",
+            writer_file,
+        ])
         inputs.add(writer_file)
     else:
         action_exe = ctx.attr._build_data_writer[DefaultInfo].files_to_run

python/private/pypi/whl_extract.bzl

@@ -12,7 +12,7 @@ def whl_extract(rctx, *, whl_path, logger):
         whl_path: the whl path to extract.
         logger: The logger to use
     """
-    install_dir_path = whl_path.dirname.get_child("site-packages")
+    install_dir_path = rctx.path("site-packages")
     repo_utils.extract(
         rctx,
         archive = whl_path,
@@ -30,7 +30,6 @@ def whl_extract(rctx, *, whl_path, logger):
         dist_info_dir.get_child("INSTALLER"),
         "https://github.com/bazel-contrib/rules_python#pipstar",
     )
-    repo_root_dir = whl_path.dirname
 
     # Get the <prefix>.dist_info dir name
     data_dir = dist_info_dir.dirname.get_child(dist_info_dir.basename[:-len(".dist-info")] + ".data")
@@ -54,7 +53,7 @@ def whl_extract(rctx, *, whl_path, logger):
                 # The prefix does not exist in the wheel, we can continue
                 continue
 
-            for (src, dest) in merge_trees(src, repo_root_dir.get_child(dest_prefix)):
+            for (src, dest) in merge_trees(src, rctx.path(dest_prefix)):
                 logger.debug(lambda: "Renaming: {} -> {}".format(src, dest))
                 rctx.rename(src, dest)