Skip to content

Commit 79fe59d

Browse files
committed
chore(release): format RC comment links as bulleted list
1 parent 74bcfbd commit 79fe59d

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

tests/tools/private/release/release_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -965,7 +965,7 @@ def test_create_rc_success_first_rc(self):
965965
comment_call_args = self.mock_gh.post_issue_comment.call_args[0]
966966
self.assertEqual(comment_call_args[0], 123)
967967
self.assertIn(
968-
"Trigger Release Workflow: [Release Workflow](https://github.com/bazel-contrib/rules_python/actions/workflows/release.yml)",
968+
"- Trigger Release Workflow: [Release Workflow](https://github.com/bazel-contrib/rules_python/actions/workflows/release.yml)",
969969
comment_call_args[1],
970970
)
971971

@@ -1002,7 +1002,7 @@ def test_create_rc_success_next_rc(self):
10021002
comment_call_args = self.mock_gh.post_issue_comment.call_args[0]
10031003
self.assertEqual(comment_call_args[0], 123)
10041004
self.assertIn(
1005-
"Trigger Release Workflow: [Release Workflow](https://github.com/bazel-contrib/rules_python/actions/workflows/release.yml)",
1005+
"- Trigger Release Workflow: [Release Workflow](https://github.com/bazel-contrib/rules_python/actions/workflows/release.yml)",
10061006
comment_call_args[1],
10071007
)
10081008

tools/private/release/create_rc.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,9 @@ def cmd_create_rc(args):
105105
106106
Release Candidate **{next_rc}** has been successfully generated and tagged on branch `{branch_name}`.
107107
108-
View Tag: [{next_rc}]({tag_url})
109-
Track BCR Progress: [Search BCR Pull Requests]({bcr_search_url})
110-
Trigger Release Workflow: [Release Workflow]({release_workflow_url})"""
108+
- View Tag: [{next_rc}]({tag_url})
109+
- Track BCR Progress: [Search BCR Pull Requests]({bcr_search_url})
110+
- Trigger Release Workflow: [Release Workflow]({release_workflow_url})"""
111111
gh.post_issue_comment(args.issue, comment_body)
112112
print("RC creation completed successfully!")
113113
return 0

0 commit comments

Comments
 (0)