Skip to content

Commit 82b9acc

Browse files
committed
refactor: rename is_venvs_site_packages to _is_venvs_site_packages
The original target was intended to be internal-only, so it has been renamed and all references updated. No alias was added as per instructions.
1 parent 194693c commit 82b9acc

3 files changed

Lines changed: 11 additions & 11 deletions

File tree

python/config_settings/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ string_flag(
229229
)
230230

231231
config_setting(
232-
name = "is_venvs_site_packages",
232+
name = "_is_venvs_site_packages",
233233
flag_values = {
234234
":venvs_site_packages": VenvsSitePackages.YES,
235235
},

python/private/pypi/whl_library_targets.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ _BAZEL_REPO_FILE_GLOBS = [
4343
"WORKSPACE.bazel",
4444
]
4545

46-
_IS_VENV_SITE_PACKAGES_YES = Label("//python/config_settings:is_venvs_site_packages")
46+
_IS_VENV_SITE_PACKAGES_YES = Label("//python/config_settings:_is_venvs_site_packages")
4747

4848
def whl_library_targets_from_requires(
4949
*,

tests/pypi/whl_library_targets/whl_library_targets_tests.bzl

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -245,11 +245,11 @@ def _test_whl_and_library_deps_from_requires(env):
245245
env.expect.that_dict(py_library_call).contains_exactly({
246246
"name": "pkg",
247247
"srcs": ["site-packages/foo/SRCS.py"] + select({
248-
Label("//python/config_settings:is_venvs_site_packages"): [],
248+
Label("//python/config_settings:_is_venvs_site_packages"): [],
249249
"//conditions:default": ["_create_inits_target"],
250250
}),
251251
"pyi_srcs": ["site-packages/foo/PYI.pyi"],
252-
"data": ["site-packages/foo/DATA.txt"] + select({Label("//python/config_settings:is_venvs_site_packages"): ["data"], "//conditions:default": []}),
252+
"data": ["site-packages/foo/DATA.txt"] + select({Label("//python/config_settings:_is_venvs_site_packages"): ["data"], "//conditions:default": []}),
253253
"imports": ["site-packages"],
254254
"deps": ["@pypi//bar:pkg"] + select({
255255
":is_include_bar_baz_true": ["@pypi//bar_baz:pkg"],
@@ -259,7 +259,7 @@ def _test_whl_and_library_deps_from_requires(env):
259259
"visibility": ["//visibility:public"],
260260
"experimental_venvs_site_packages": Label("//python/config_settings:venvs_site_packages"),
261261
"namespace_package_files": [] + select({
262-
Label("//python/config_settings:is_venvs_site_packages"): [],
262+
Label("//python/config_settings:_is_venvs_site_packages"): [],
263263
"//conditions:default": ["_create_inits_target"],
264264
}),
265265
}) # buildifier: @unsorted-dict-items
@@ -361,11 +361,11 @@ def _test_whl_and_library_deps(env):
361361
env.expect.that_dict(py_library_calls[0]).contains_exactly({
362362
"name": "pkg",
363363
"srcs": ["site-packages/foo/SRCS.py"] + select({
364-
Label("//python/config_settings:is_venvs_site_packages"): [],
364+
Label("//python/config_settings:_is_venvs_site_packages"): [],
365365
"//conditions:default": ["_create_inits_target"],
366366
}),
367367
"pyi_srcs": ["site-packages/foo/PYI.pyi"],
368-
"data": ["site-packages/foo/DATA.txt"] + select({Label("//python/config_settings:is_venvs_site_packages"): ["data"], "//conditions:default": []}),
368+
"data": ["site-packages/foo/DATA.txt"] + select({Label("//python/config_settings:_is_venvs_site_packages"): ["data"], "//conditions:default": []}),
369369
"imports": ["site-packages"],
370370
"deps": [
371371
"@pypi_bar_baz//:pkg",
@@ -386,7 +386,7 @@ def _test_whl_and_library_deps(env):
386386
"visibility": ["//visibility:public"],
387387
"experimental_venvs_site_packages": Label("//python/config_settings:venvs_site_packages"),
388388
"namespace_package_files": [] + select({
389-
Label("//python/config_settings:is_venvs_site_packages"): [],
389+
Label("//python/config_settings:_is_venvs_site_packages"): [],
390390
"//conditions:default": ["_create_inits_target"],
391391
}),
392392
}) # buildifier: @unsorted-dict-items
@@ -444,11 +444,11 @@ def _test_group(env):
444444
).contains_exactly({
445445
"name": "_pkg",
446446
"srcs": ["site-packages/foo/srcs.py"] + select({
447-
Label("//python/config_settings:is_venvs_site_packages"): [],
447+
Label("//python/config_settings:_is_venvs_site_packages"): [],
448448
"//conditions:default": ["_create_inits_target"],
449449
}),
450450
"pyi_srcs": ["site-packages/foo/pyi.pyi"],
451-
"data": ["site-packages/foo/data.txt"] + select({Label("//python/config_settings:is_venvs_site_packages"): ["data"], "//conditions:default": []}),
451+
"data": ["site-packages/foo/data.txt"] + select({Label("//python/config_settings:_is_venvs_site_packages"): ["data"], "//conditions:default": []}),
452452
"imports": ["site-packages"],
453453
"deps": ["@pypi_bar_baz//:pkg"] + select({
454454
"@platforms//os:linux": ["@pypi_box//:pkg"],
@@ -459,7 +459,7 @@ def _test_group(env):
459459
"visibility": ["@pypi__config//_groups:__pkg__"],
460460
"experimental_venvs_site_packages": Label("//python/config_settings:venvs_site_packages"),
461461
"namespace_package_files": [] + select({
462-
Label("//python/config_settings:is_venvs_site_packages"): [],
462+
Label("//python/config_settings:_is_venvs_site_packages"): [],
463463
"//conditions:default": ["_create_inits_target"],
464464
}),
465465
}) # buildifier: @unsorted-dict-items

0 commit comments

Comments
 (0)