Skip to content

Commit 9e1e5d9

Browse files
committed
test: pass logger through simpleapi_download test mocks
The `read_simpleapi` mocks in simpleapi_download_tests.bzl need to accept the new `logger` keyword that `simpleapi_download` now threads through, otherwise they error with: read_simpleapi() got unexpected keyword argument: logger
1 parent 33d7ed7 commit 9e1e5d9

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

tests/pypi/simpleapi_download/simpleapi_download_tests.bzl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ _tests = []
2424
def _test_simple(env):
2525
calls = []
2626

27-
def read_simpleapi(ctx, url, versions, attr, cache, get_auth, block, parse_index):
27+
def read_simpleapi(ctx, url, versions, attr, cache, get_auth, block, parse_index, logger):
2828
if parse_index:
2929
return struct(
3030
success = True,
@@ -36,7 +36,7 @@ def _test_simple(env):
3636
},
3737
)
3838

39-
_ = ctx, attr, cache, get_auth, versions # buildifier: disable=unused-variable
39+
_ = ctx, attr, cache, get_auth, versions, logger # buildifier: disable=unused-variable
4040
env.expect.that_bool(block).equals(False)
4141
calls.append(url)
4242
return struct(
@@ -94,7 +94,7 @@ def _test_index_overrides(env):
9494
calls = []
9595
fails = []
9696

97-
def read_simpleapi(ctx, *, url, versions, attr, cache, get_auth, block, parse_index):
97+
def read_simpleapi(ctx, *, url, versions, attr, cache, get_auth, block, parse_index, logger):
9898
if parse_index:
9999
return struct(
100100
success = True,
@@ -108,7 +108,7 @@ def _test_index_overrides(env):
108108
},
109109
)
110110

111-
_ = ctx, attr, cache, get_auth, versions # buildifier: disable=unused-variable
111+
_ = ctx, attr, cache, get_auth, versions, logger # buildifier: disable=unused-variable
112112
env.expect.that_bool(block).equals(False)
113113
calls.append(url)
114114
return struct(

0 commit comments

Comments
 (0)