Skip to content

Commit a996fce

Browse files
committed
simplify the initial port/uniification
1 parent a9056b1 commit a996fce

3 files changed

Lines changed: 52 additions & 105 deletions

File tree

.bazelci/presubmit.yml

Lines changed: 46 additions & 101 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,50 @@ buildifier:
9191
- //tests:version_3_13_test
9292
- //tests:version_3_14_test
9393
- //tests:version_default_test
94+
95+
matrix:
96+
platform:
97+
- ubuntu2204
98+
- debian11
99+
- macos_arm64
100+
- windows
101+
bazel: [7.*, 8.*, 9.*]
102+
94103
tasks:
104+
bcr_test:
105+
name: BCR test module
106+
platform: ${{ platform }}
107+
working_directory: examples/bzlmod
108+
bazel: ${{ bazel }}
109+
test_flags:
110+
- "--keep_going"
111+
# Without these cxxopts, BCR's Mac builds fail
112+
- '--cxxopt=-std=c++14'
113+
- '--host_cxxopt=-std=c++14'
114+
build_targets:
115+
- "//..."
116+
test_targets:
117+
- "//..."
118+
119+
bcr_gazelle_test:
120+
name: "Run test module"
121+
platform: ${{ platform }}
122+
bazel: ${{ bazel }}
123+
working_directory: gazelle/examples/bzlmod_build_file_generation
124+
shell_commands:
125+
- "echo 'common --override_module=rules_python=' >> .bazelrc"
126+
- "bazel run //:gazelle_python_manifest.update"
127+
- "bazel run //:gazelle -- update"
128+
batch_commands:
129+
- "echo common --override_module=rules_python= >> .bazelrc"
130+
- "bazel run //:gazelle_python_manifest.update"
131+
- "bazel run //:gazelle -- update"
132+
build_targets:
133+
- "//..."
134+
- ":modules_map"
135+
test_targets:
136+
- "//..."
137+
95138
gazelle_extension_min:
96139
<<: *common_workspace_flags_min_bazel
97140
<<: *minimum_supported_version
@@ -262,113 +305,15 @@ tasks:
262305
working_directory: examples/build_file_generation
263306
platform: windows
264307

265-
integration_test_bzlmod_ubuntu_min:
266-
<<: *minimum_supported_version
267-
<<: *reusable_build_test_all
268-
coverage_targets: ["//:test"]
269-
name: "examples/bzlmod: Ubuntu, minimum Bazel"
270-
working_directory: examples/bzlmod
271-
platform: ubuntu2204
272-
bazel: 7.x
273-
integration_test_bzlmod_ubuntu:
274-
<<: *reusable_build_test_all
275-
<<: *coverage_targets_example_bzlmod
276-
name: "examples/bzlmod: Ubuntu"
277-
working_directory: examples/bzlmod
278-
platform: ubuntu2204
279-
bazel: 7.x
280-
integration_test_bzlmod_ubuntu_upcoming:
281-
<<: *reusable_build_test_all
282-
<<: *coverage_targets_example_bzlmod
283-
name: "examples/bzlmod: Ubuntu, upcoming Bazel"
284-
working_directory: examples/bzlmod
285-
platform: ubuntu2204
286-
bazel: last_rc
287-
integration_test_bzlmod_debian:
288-
<<: *reusable_build_test_all
289-
<<: *coverage_targets_example_bzlmod
290-
name: "examples/bzlmod: Debian"
291-
working_directory: examples/bzlmod
292-
platform: debian11
293-
bazel: 7.x
294308
integration_test_bzlmod_ubuntu_vendor:
295309
<<: *reusable_build_test_all
296310
name: "examples/bzlmod: bazel vendor"
297311
working_directory: examples/bzlmod
298312
platform: ubuntu2204
299313
shell_commands:
300-
- "bazel vendor --vendor_dir=./vendor //..."
301-
- "bazel build --vendor_dir=./vendor //..."
302-
- "rm -rf ./vendor"
303-
integration_test_bzlmod_macos:
304-
<<: *reusable_build_test_all
305-
<<: *coverage_targets_example_bzlmod
306-
name: "examples/bzlmod: macOS"
307-
working_directory: examples/bzlmod
308-
platform: macos_arm64
309-
bazel: 7.x
310-
integration_test_bzlmod_macos_upcoming:
311-
<<: *reusable_build_test_all
312-
<<: *coverage_targets_example_bzlmod
313-
name: "examples/bzlmod: macOS, upcoming Bazel"
314-
working_directory: examples/bzlmod
315-
platform: macos_arm64
316-
bazel: last_rc
317-
integration_test_bzlmod_windows:
318-
<<: *reusable_build_test_all
319-
# coverage is not supported on Windows
320-
name: "examples/bzlmod: Windows"
321-
working_directory: examples/bzlmod
322-
platform: windows
323-
bazel: 7.x
324-
integration_test_bzlmod_windows_upcoming:
325-
<<: *reusable_build_test_all
326-
# coverage is not supported on Windows
327-
name: "examples/bzlmod: Windows, upcoming Bazel"
328-
working_directory: examples/bzlmod
329-
platform: windows
330-
bazel: last_rc
331-
332-
integration_test_bzlmod_generate_build_file_generation_ubuntu_min:
333-
<<: *minimum_supported_version
334-
<<: *reusable_build_test_all
335-
<<: *coverage_targets_example_bzlmod_build_file_generation
336-
name: "gazelle/examples/bzlmod_build_file_generation: Ubuntu, minimum Bazel"
337-
working_directory: gazelle/examples/bzlmod_build_file_generation
338-
platform: ubuntu2204
339-
bazel: 7.x
340-
integration_test_bzlmod_generation_build_files_ubuntu:
341-
<<: *reusable_build_test_all
342-
<<: *coverage_targets_example_bzlmod_build_file_generation
343-
name: "gazelle/examples/bzlmod_build_file_generation: Ubuntu"
344-
working_directory: gazelle/examples/bzlmod_build_file_generation
345-
platform: ubuntu2204
346-
integration_test_bzlmod_generation_build_files_ubuntu_run:
347-
<<: *reusable_build_test_all
348-
name: "gazelle/examples/bzlmod_build_file_generation: Ubuntu, Gazelle and pip"
349-
working_directory: gazelle/examples/bzlmod_build_file_generation
350-
platform: ubuntu2204
351-
shell_commands:
352-
- "bazel run //:gazelle_python_manifest.update"
353-
- "bazel run //:gazelle -- update"
354-
integration_test_bzlmod_build_file_generation_debian:
355-
<<: *reusable_build_test_all
356-
<<: *coverage_targets_example_bzlmod_build_file_generation
357-
name: "gazelle/examples/bzlmod_build_file_generation: Debian"
358-
working_directory: gazelle/examples/bzlmod_build_file_generation
359-
platform: debian11
360-
integration_test_bzlmod_build_file_generation_macos:
361-
<<: *reusable_build_test_all
362-
<<: *coverage_targets_example_bzlmod_build_file_generation
363-
name: "gazelle/examples/bzlmod_build_file_generation: MacOS"
364-
working_directory: gazelle/examples/bzlmod_build_file_generation
365-
platform: macos_arm64
366-
integration_test_bzlmod_build_file_generation_windows:
367-
<<: *reusable_build_test_all
368-
# coverage is not supported on Windows
369-
name: "gazelle/examples/bzlmod_build_file_generation: Windows"
370-
working_directory: gazelle/examples/bzlmod_build_file_generation
371-
platform: windows
314+
- "bazel vendor --vendor_dir=./vendor //..."
315+
- "bazel build --vendor_dir=./vendor //..."
316+
- "rm -rf ./vendor"
372317

373318
integration_test_multi_python_versions_ubuntu_workspace:
374319
<<: *reusable_build_test_all

.bcr/gazelle/presubmit.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
bcr_test_module:
1616
module_path: "examples/bzlmod_build_file_generation"
1717
matrix:
18-
platform: ["debian11", "macos", "ubuntu2004", "windows"]
19-
bazel: [7.x, 8.x]
18+
platform: ["debian11", "macos", "ubuntu2204", "windows"]
19+
bazel: [7.x, 8.x, 9.x]
2020
tasks:
2121
run_tests:
2222
name: "Run test module"

.bcr/presubmit.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
bcr_test_module:
1616
module_path: "examples/bzlmod"
1717
matrix:
18-
platform: ["debian11", "macos", "ubuntu2004", "windows"]
19-
bazel: [7.x, 8.x]
18+
platform: ["debian11", "macos", "ubuntu2204", "windows"]
19+
bazel: [7.x, 8.x, 9.x]
2020
tasks:
2121
run_tests:
2222
name: "Run test module"
@@ -27,5 +27,7 @@ bcr_test_module:
2727
# Without these cxxopts, BCR's Mac builds fail
2828
- '--cxxopt=-std=c++14'
2929
- '--host_cxxopt=-std=c++14'
30+
build_targets:
31+
- "//..."
3032
test_targets:
3133
- "//..."

0 commit comments

Comments
 (0)