Skip to content

Commit aad3290

Browse files
committed
fix unit tests
1 parent dd3a0f6 commit aad3290

2 files changed

Lines changed: 17 additions & 1 deletion

File tree

python/private/pypi/requirements_files_by_platform.bzl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,6 @@ def requirements_files_by_platform(
175175
platform
176176
for filter_or_platform in specifier.split(",")
177177
for platform in (_default_platforms(filter = filter_or_platform, platforms = platforms) if filter_or_platform.endswith("*") else [filter_or_platform])
178-
# TODO @aignas 2025-12-06: add a test
179178
if platform in input_platforms
180179
]
181180
for file, specifier in requirements_by_platform.items()

tests/pypi/requirements_files_by_platform/requirements_files_by_platform_tests.bzl

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,12 @@ def _test_simple_limited(env):
115115
},
116116
platforms = ["linux_x86_64", "osx_x86_64"],
117117
),
118+
requirements_files_by_platform(
119+
requirements_by_platform = {
120+
"requirements_lock": "linux_x86_64,osx_aarch64,osx_x86_64",
121+
},
122+
platforms = ["linux_x86_64", "osx_x86_64", "windows_x86_64"],
123+
),
118124
]:
119125
env.expect.that_dict(got).contains_exactly({
120126
"requirements_lock": [
@@ -219,6 +225,17 @@ def _test_os_arch_requirements_with_default(env):
219225
"requirements_linux": "linux_x86_64,linux_aarch64",
220226
},
221227
requirements_lock = "requirements_lock",
228+
platforms = [
229+
"linux_super_exotic",
230+
"linux_x86_64",
231+
"linux_aarch64",
232+
"linux_arm",
233+
"linux_ppc",
234+
"linux_s390x",
235+
"osx_aarch64",
236+
"osx_x86_64",
237+
"windows_x86_64",
238+
],
222239
)
223240
env.expect.that_dict(got).contains_exactly({
224241
"requirements_exotic": ["linux_super_exotic"],

0 commit comments

Comments
 (0)