Skip to content

Commit deb78c3

Browse files
committed
refactor(twine): use py_console_script_binary
1 parent 8633255 commit deb78c3

2 files changed

Lines changed: 6 additions & 9 deletions

File tree

python/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ bzl_library(
8888
name = "packaging_bzl",
8989
srcs = ["packaging.bzl"],
9090
deps = [
91-
":py_binary_bzl",
91+
"//python/entry_points:py_console_script_binary_bzl",
9292
"//python/private:bzlmod_enabled_bzl",
9393
"//python/private:py_package_bzl",
9494
"//python/private:py_wheel_bzl",

python/packaging.bzl

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"""Public API for for building wheels."""
1616

1717
load("@bazel_skylib//rules:native_binary.bzl", "native_binary")
18-
load("//python:py_binary.bzl", "py_binary")
18+
load("//python/entry_points:py_console_script_binary.bzl", "py_console_script_binary")
1919
load("//python/private:bzlmod_enabled.bzl", "BZLMOD_ENABLED")
2020
load("//python/private:py_package.bzl", "py_package_lib")
2121
load("//python/private:py_wheel.bzl", _PyWheelInfo = "PyWheelInfo", _py_wheel = "py_wheel")
@@ -219,16 +219,13 @@ def py_wheel(
219219
if not twine.endswith(":pkg"):
220220
fail("twine label should look like @my_twine_repo//:pkg")
221221

222-
twine_main = twine.replace(":pkg", ":rules_python_wheel_entry_point_twine.py")
223-
224-
py_binary(
222+
py_console_script_binary(
225223
name = "{}.publish".format(name),
226-
srcs = [twine_main],
224+
pkg = twine,
225+
imports = ["."],
227226
args = twine_args,
228227
data = [dist_target],
229-
imports = ["."],
230-
main = twine_main,
231-
deps = [twine],
228+
script = "twine",
232229
tags = manual_tags,
233230
visibility = kwargs.get("visibility"),
234231
**copy_propagating_kwargs(kwargs)

0 commit comments

Comments
 (0)