pre-commit: fix issues reported by ruff-check

Author: aignas

examples/bzlmod/test.py

@@ -58,7 +58,7 @@ def test_coverage_sys_path(self):
                 f"sys.path has {len(sys.path)} items:\n    {all_paths}",
             )
 
-        first_item, last_item = sys.path[0], sys.path[-1]
+        first_item = sys.path[0]
         self.assertFalse(
             first_item.endswith("coverage"),
             f"Expected the first item in sys.path '{first_item}' to not be related to coverage",

examples/wheel/wheel_test.py

@@ -523,7 +523,6 @@ def test_minimal_data_files(self):
 
         with zipfile.ZipFile(filename) as zf:
             self.assertAllEntriesHasReproducibleMetadata(zf)
-            metadata_file = None
             self.assertEqual(
                 zf.namelist(),
                 [

python/bin/repl_stub.py

@@ -13,13 +13,13 @@
 The logic for PYTHONSTARTUP is handled in python/private/repl_template.py.
 """
 
-# Capture the globals from PYTHONSTARTUP so we can pass them on to the console.
-console_locals = globals().copy()
-
 import code
 import rlcompleter
 import sys
 
+# Capture the globals from PYTHONSTARTUP so we can pass them on to the console.
+console_locals = globals().copy()
+
 
 class DynamicCompleter(rlcompleter.Completer):
     """

python/private/py_console_script_gen.py

@@ -72,7 +72,7 @@ class EntryPointsParser(configparser.ConfigParser):
     optionxform = staticmethod(str)
 
 
-def _guess_entry_point(guess: str, console_scripts: dict[string, string]) -> str | None:
+def _guess_entry_point(guess: str, console_scripts: dict[str, str]) -> str | None:
     for key, candidate in console_scripts.items():
         if guess == key:
             return candidate

python/private/pypi/namespace_pkg_tmpl.py

@@ -1,2 +1,2 @@
 # __path__ manipulation added by bazel-contrib/rules_python to support namespace pkgs.
-__path__ = __import__("pkgutil").extend_path(__path__, __name__)
+__path__ = __import__("pkgutil").extend_path(__path__, __name__)  # noqa: F821

python/private/site_init_template.py

@@ -131,8 +131,6 @@ def _setup_sys_path():
     """Perform Bazel/binary specific sys.path setup."""
     _print_verbose("site init: initial sys.path:\n", "\n".join(sys.path))
     seen = set(sys.path)
-    python_path_entries = []
-
     def _maybe_add_path(path, reason):
         if path in seen:
             return

python/private/stage2_bootstrap_template.py

@@ -131,6 +131,7 @@ def get_windows_path_with_unc_prefix(path):
         return path
 
     # Lets start the unicode fun
+    unicode_prefix = "\\\\?\\"
     if path.startswith(unicode_prefix):
         return path
 

python/private/zipapp/zip_main_template.py

@@ -15,22 +15,21 @@
 # for the program and may be skipped entirely; the self-executable zip
 # preamble may jump directly to the stage2 bootstrap.
 
-import sys
-
-# The Python interpreter unconditionally prepends the directory containing this
-# script (following symlinks) to the import path. This is the cause of #9239,
-# and is a special case of #7091. We therefore explicitly delete that entry.
-# TODO(#7091): Remove this hack when no longer necessary.
-del sys.path[0]
-
 import os
 import shutil
 import stat
 import subprocess
+import sys
 import tempfile
 import zipfile
 from os.path import basename, dirname, join, normpath
 
+# The Python interpreter unconditionally prepends the directory containing this
+# script (following symlinks) to the import path. This is the cause of #9239,
+# and is a special case of #7091. We therefore explicitly delete that entry.
+# TODO(#7091): Remove this hack when no longer necessary.
+del sys.path[0]
+
 # runfiles-root-relative path
 _STAGE2_BOOTSTRAP = "%stage2_bootstrap%"
 # runfiles-root-relative path to venv's bin/python3. Empty if venv not being used.

python/runfiles/__init__.py

@@ -12,4 +12,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from .runfiles import *
+from .runfiles import Create as Create, CreateDirectoryBased as CreateDirectoryBased, CreateManifestBased as CreateManifestBased, Path as Path, Runfiles as Runfiles  # noqa: F401

sphinxdocs/sphinxdocs/private/sphinx_server.py

@@ -19,7 +19,6 @@ class DirectoryHandler(server.SimpleHTTPRequestHandler):
         def __init__(self, *args, **kwargs):
             super().__init__(directory=serve_directory, *args, **kwargs)
 
-    address = ("0.0.0.0", 8000)
     # with server.ThreadingHTTPServer(address, DirectoryHandler) as (ip, port, httpd):
     with _start_server(DirectoryHandler, "0.0.0.0", 8000) as (ip, port, httpd):