chore(release): release automation fixes and refactoring (#3885)

- Fix promote_rc dry run message to use correct remote.
- Support spaces in metadata parsing and format commit SHA with space
for GitHub autolinking.
- Trigger release publish workflow from create_rc workflow using
workflow_call.
- Replace version markers during backport processing.
- Split release_test.py into separate files for each command.
- Refactor release tool BUILD targets to use py_library and glob.

Author: rickeylev

.github/workflows/release_create_rc.yaml

@@ -13,8 +13,10 @@ permissions:
   issues: write
 
 jobs:
-  generate_rc:
+  tag_rc:
     runs-on: ubuntu-latest
+    outputs:
+      tag_name: ${{ steps.tagger.outputs.tag_name }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v7
@@ -32,8 +34,16 @@ jobs:
           git config --global user.email "41898282+github-actions[bot]@users.noreply.github.com"
 
       - name: Attempt RC Tagging
+        id: tagger
         run: |
           bazel run //tools/private/release -- \
             create-rc --issue ${{ inputs.issue }} --remote origin
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+  call_release:
+    needs: tag_rc
+    uses: ./.github/workflows/release_publish.yaml
+    with:
+      tag_name: ${{ needs.tag_rc.outputs.tag_name }}
+    secrets: inherit

.github/workflows/release.yml .github/workflows/release_publish.yaml.github/workflows/release.yml renamed to .github/workflows/release_publish.yaml

@@ -13,7 +13,7 @@
 # limitations under the License.
 
 # Cut a release whenever a new tag is pushed to the repo.
-name: Release
+name: "Release: Publish"
 
 on:
   push:
@@ -33,6 +33,17 @@ on:
     secrets:
       publish_token:
         required: false
+  workflow_call:
+    inputs:
+      tag_name:
+        description: "release tag: tag that will be released"
+        required: true
+        type: string
+      publish_to_pypi:
+        description: 'Publish to PyPI'
+        required: false
+        type: boolean
+        default: true
 
 jobs:
   release:
@@ -42,7 +53,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v7
         with:
-          ref: ${{ github.ref_name }}
+          ref: ${{ inputs.tag_name || github.ref_name }}
       - name: Create release archive and notes
         run: .github/workflows/create_archive_and_notes.sh ${{ inputs.tag_name || github.ref_name }}
       - name: Release
@@ -73,7 +84,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v7
         with:
-          ref: ${{ github.tag_name || github.ref_name }}
+          ref: ${{ inputs.tag_name || github.ref_name }}
       - if: github.event_name == 'push' || github.event.inputs.publish_to_pypi
         env:
           # This special value tells pypi that the user identity is supplied within the token

RELEASING.md

@@ -66,14 +66,14 @@ specific commit.
 To trigger the workflow, use the `gh workflow run` command:
 
 ```shell
-gh workflow run release.yml --ref <TAG>
+gh workflow run release_publish.yaml --ref <TAG>
 ```
 
 By default, the workflow will publish the wheel to PyPI. To skip this step,
 you can set the `publish_to_pypi` input to `false`:
 
 ```shell
-gh workflow run release.yml --ref <TAG> -f publish_to_pypi=false
+gh workflow run release_publish.yaml --ref <TAG> -f publish_to_pypi=false
 ```
 
 ### Determining Semantic Version

tests/tools/private/release/BUILD.bazel

@@ -1,10 +1,97 @@
-load("@rules_python//python:defs.bzl", "py_test")
+load("@rules_python//python:defs.bzl", "py_library", "py_test")
+
+py_library(
+    name = "release_test_helper",
+    srcs = ["release_test_helper.py"],
+    deps = [
+        "//tools/private/release:release_lib",
+    ],
+)
+
+py_test(
+    name = "changelog_news_test",
+    srcs = ["changelog_news_test.py"],
+    deps = [
+        ":release_test_helper",
+        "//tools/private/release:release_lib",
+    ],
+)
+
+py_test(
+    name = "create_rc_test",
+    srcs = ["create_rc_test.py"],
+    deps = [
+        ":release_test_helper",
+        "//tools/private/release:release_lib",
+    ],
+)
+
+py_test(
+    name = "create_release_branch_test",
+    srcs = ["create_release_branch_test.py"],
+    deps = [
+        ":release_test_helper",
+        "//tools/private/release:release_lib",
+    ],
+)
+
+py_test(
+    name = "git_test",
+    srcs = ["git_test.py"],
+    deps = [
+        "//tools/private/release:release_lib",
+    ],
+)
+
+py_test(
+    name = "prepare_test",
+    srcs = ["prepare_test.py"],
+    deps = [
+        ":release_test_helper",
+        "//tools/private/release:release_lib",
+    ],
+)
+
+py_test(
+    name = "process_backports_test",
+    srcs = ["process_backports_test.py"],
+    deps = [
+        ":release_test_helper",
+        "//tools/private/release:release_lib",
+    ],
+)
+
+py_test(
+    name = "promote_rc_test",
+    srcs = ["promote_rc_test.py"],
+    deps = [
+        ":release_test_helper",
+        "//tools/private/release:release_lib",
+    ],
+)
+
+py_test(
+    name = "release_issue_test",
+    srcs = ["release_issue_test.py"],
+    deps = [
+        "//tools/private/release:release_lib",
+    ],
+)
 
 py_test(
     name = "release_test",
     srcs = ["release_test.py"],
     deps = [
-        "//tools/private/release",
+        "//tools/private/release:release_lib",
+    ],
+)
+
+py_test(
+    name = "utils_test",
+    srcs = ["utils_test.py"],
+    deps = [
+        ":release_test_helper",
+        "//tools/private/release:release_lib",
         "@dev_pip//packaging",
     ],
 )