Skip to content

chore: enable pipstar for experimental_index_url users #3428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 4 commits into from
Nov 23, 2025
Merged

chore: enable pipstar for experimental_index_url users #3428

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cdecbae
chore: enable pipstar for experimental_index_url users
aignas Nov 23, 2025
88189be
also use pipstar in the hub_builder
aignas Nov 23, 2025
e13ecb8
improve the logic in whl_library
aignas Nov 23, 2025
97da662
Merge branch 'main' into aignas.enable_pipstar_for_experimental_index…
rickeylev Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ END_UNRELEASED_TEMPLATE
### Changed
* (toolchains) Use toolchains from the [20251031] release.
* (gazelle) Internally split modules mapping generation to be per-wheel for concurrency and caching.
* (pip) `pipstar` has been enabled for all `whl_library` instances where the whl
is passed through a label or downloaded using the bazel downloader
([#2949](https://github.com/bazel-contrib/rules_python/issues/2949)).

{#v0-0-0-fixed}
### Fixed
Expand Down
8 changes: 6 additions & 2 deletions python/private/pypi/whl_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,11 @@ def _whl_library_impl(rctx):

args = _parse_optional_attrs(rctx, args, extra_pip_args)

if not whl_path:
enable_pipstar = rp_config.enable_pipstar and rctx.attr.config_load
if whl_path:
# Enable pipstar for any whls that are downloaded without `pip`
enable_pipstar = True
else:
Comment thread
aignas marked this conversation as resolved.
Outdated
if rctx.attr.urls:
op_tmpl = "whl_library.BuildWheelFromSource({name}, {requirement})"
elif rctx.attr.download_only:
Expand Down Expand Up @@ -374,7 +378,7 @@ def _whl_library_impl(rctx):
# disable pipstar for that particular case.
#
# Remove non-pipstar and config_load check when we release rules_python 2.
if rp_config.enable_pipstar and rctx.attr.config_load:
if enable_pipstar:
pypi_repo_utils.execute_checked(
rctx,
op = "whl_library.ExtractWheel({}, {})".format(rctx.attr.name, whl_path),
Expand Down