Skip to content

fix(pipstar): fix whl extraction and flip pipstar=true #3461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 19 commits into from
Dec 17, 2025
Merged

fix(pipstar): fix whl extraction and flip pipstar=true #3461

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0054d0f
feat: flip pipstar to be on by default
aignas Dec 14, 2025
5a6f2d0
Update CHANGELOG.md
rickeylev Dec 15, 2025
8869712
Merge branch 'main' into chore.flip-pipstar
aignas Dec 15, 2025
389d4f7
wip
aignas Dec 15, 2025
91961e6
fixup
aignas Dec 15, 2025
e1da86f
fixup
aignas Dec 15, 2025
a127586
disable pipstar by default on bazel 7
aignas Dec 15, 2025
c6a8811
do whl extracting only on bazel8 and above
aignas Dec 16, 2025
4eca3d1
further refactor
aignas Dec 16, 2025
2c0b7f9
add a marker file to signify the installer of the wheel
aignas Dec 16, 2025
0b610c4
revert the internal_config_repo to use the version to set default pip…
aignas Dec 16, 2025
c1a8a2f
fix the metadata reading
aignas Dec 16, 2025
4033653
Merge branch 'main' into chore.flip-pipstar
aignas Dec 16, 2025
4d8adbb
disable pipstar by default on bazel 7
aignas Dec 16, 2025
2f3ac0a
add a separate flag for extracting wheels
aignas Dec 16, 2025
8ed1c37
it is safe to have the env decide pipstar enabling
aignas Dec 16, 2025
943df67
Merge branch 'main' into chore.flip-pipstar
aignas Dec 17, 2025
e1e7813
fix the extras
aignas Dec 17, 2025
508f9b6
Merge branch 'main' into chore.flip-pipstar
aignas Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ END_UNRELEASED_TEMPLATE
* (pip) `pipstar` has been enabled for all `whl_library` instances where the whl
is passed through a label or downloaded using the bazel downloader
([#2949](https://github.com/bazel-contrib/rules_python/issues/2949)).
* (pypi) `pipstar` flag default has been flipped to be on by default.
It can be disabled through `RULES_PYTHON_ENABLE_PIPSTAR=0` environment variable.
If you do need to disable it, please add a comment to
[#2949](https://github.com/bazel-contrib/rules_python/issues/2949).
* (gazelle deps) rules_go bumped from 0.55.1 to 0.59.0
* (gazelle deps) gazelle bumped from 0.36.0 to 0.47.0

Expand Down
2 changes: 1 addition & 1 deletion python/private/internal_config_repo.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ load("//python/private:text_util.bzl", "render")
load(":repo_utils.bzl", "repo_utils")

_ENABLE_PIPSTAR_ENVVAR_NAME = "RULES_PYTHON_ENABLE_PIPSTAR"
_ENABLE_PIPSTAR_DEFAULT = "0"
_ENABLE_PIPSTAR_DEFAULT = "1"
_ENABLE_DEPRECATION_WARNINGS_ENVVAR_NAME = "RULES_PYTHON_DEPRECATION_WARNINGS"
_ENABLE_DEPRECATION_WARNINGS_DEFAULT = "0"

Expand Down